Skip to content

Update Rewards payout status messaging #11347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Nov 30, 2021

Resolves brave/brave-browser#18602

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See figma for UX designs.

Scenario 1: Payment pending messaging

  • Given that user has ad earnings for the previous month
  • And the current day of month is before the payout day
  • When the user opens the panel, the NTP, or the rewards page
  • Then the user should see the "payment pending" message.

Scenario 1: Payment processing messaging

  • Given that user has ad earnings for the previous month
  • And the current day of month is on or after the payout day and less than 4 days after the payout day
  • And the user has not received an Ad grant this month
  • When the user opens the panel, the NTP, or the rewards page
  • Then the user should see the "payment processing" message.

Scenario 3: Payment arrived messaging

  • Given that user has ad earnings for the previous month
  • And the current day of month is on or after the payout day and less than 4 days after the payout day
  • And the user has received an Ad grant this month
  • When the user opens the panel, the NTP, or the rewards page
  • Then the user should see the "payment arrived" message.

@zenparsing zenparsing force-pushed the ksmith-payout-status-link branch 3 times, most recently from 5e52a85 to bd6c177 Compare December 8, 2021 15:59
@zenparsing zenparsing force-pushed the ksmith-payout-status-link branch 3 times, most recently from 31177f8 to c090886 Compare December 15, 2021 19:17
@zenparsing zenparsing marked this pull request as ready for review December 15, 2021 19:21
@zenparsing zenparsing requested a review from a team as a code owner December 15, 2021 19:21
@zenparsing zenparsing force-pushed the ksmith-payout-status-link branch 2 times, most recently from d1e80b6 to a84794b Compare December 15, 2021 20:39
@zenparsing zenparsing force-pushed the ksmith-payout-status-link branch 3 times, most recently from 6ec3fb4 to 1e510cb Compare December 20, 2021 20:17
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing force-pushed the ksmith-payout-status-link branch 2 times, most recently from 27f44d5 to 09343b4 Compare December 21, 2021 18:25
@zenparsing
Copy link
Collaborator Author

arrived-ntp

arrived-page

arrived-panel-creator

arrived-panel-summary

pending-ntp

pending-page

pending-panel-creator

pending-panel-summary

processing-ntp

processing-page

processing-panel-creator

processing-panel-summary

@zenparsing zenparsing force-pushed the ksmith-payout-status-link branch from 09343b4 to f0f6bab Compare December 22, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Payout status button and banners for ad earnings Rewards payouts and add new state to payout banner
2 participants