Skip to content

Built Out Switch EVM Network Panel UI #10823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Built Out Switch EVM Network Panel UI

Since the AllowAddNetwork panel is basically identical to the UI needed for AllowChangeNetwork UI.
It is now a shared component with a prop to identify what its being used for panelType: 'add' | 'change'

  1. Renamed allow-add-network-panel to allow-add-change-network-panel
  2. Added conditions in the panel to display the correct UI depending on panelType
  3. We also now pass in the active tabs siteOrigin and correctly display the sites FavIcon and URL

Resolves brave/brave-browser#19072

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screen Shot 2021-11-02 at 10 24 05 AM

Screen Shot 2021-11-02 at 10 24 18 AM

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner November 2, 2021 16:44
@Douglashdaniel Douglashdaniel self-assigned this Nov 2, 2021
@Douglashdaniel Douglashdaniel added this to the 1.33.x - Nightly milestone Nov 2, 2021
@Douglashdaniel Douglashdaniel merged commit 3834d2b into master Nov 2, 2021
@Douglashdaniel Douglashdaniel deleted the switch-evm-networks-ui branch November 2, 2021 20:11
brave-builds pushed a commit that referenced this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI to switch EVM networks
2 participants