Skip to content

Resolve SE order related issue #10691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#18777

Submitter Checklist:

  • [] I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 26, 2021
@deeppandya deeppandya self-assigned this Oct 26, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit 639b139 into master Oct 26, 2021
@deeppandya deeppandya deleted the resolve_SE_order_issue_android branch October 26, 2021 16:59
brave-builds pushed a commit that referenced this pull request Oct 26, 2021
brave-builds pushed a commit that referenced this pull request Oct 26, 2021
@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ running Android 11 using the following build:

1.33.36 Chromium: 95.0.4638.54

Test Case #1 (Locale Used: Poland)

  • ensured that tapping on the URL bar on a fresh install displays the SE on-boarding modal
  • ensured that selecting Brave as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting DDG as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Google as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Bing as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Qwant as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Startpage as the search engine correctly sets both Standard & Private via SE settings

Test Case #2 (Locale Used: Spain)

  • ensured that tapping on the URL bar on a fresh install displays the SE on-boarding modal
  • ensured that selecting Brave as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting DDG as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Qwant as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Bing as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Google as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Ecosia as the search engine correctly sets both Standard & Private via SE settings
  • ensured that selecting Startpage as the search engine correctly sets both Standard & Private via SE settings

Test Case #3 (Locale Used: USA)

  • ensured that there's no SE on-boarding modal when tapping on the URL bar on a fresh install
  • ensured that Brave is set as the default browser for both Standard & Private via SE settings

Test Case #4 (Locale Used: France)

  • ensured that there's no SE on-boarding modal when tapping on the URL bar on a fresh install
  • ensured that Brave is set as the default browser for both Standard & Private via SE settings

@kjozwiak kjozwiak added this to the 1.33.x - Nightly milestone Oct 27, 2021
@kjozwiak
Copy link
Member

Adding missing 1.33.x - Nightly milestone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selecting SE from on-boarding doesn't select the correct SE
3 participants