Skip to content

Fixes reduced delivery of Brave ads campaigns with subdivision targeting - 1.32.x #10616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2021
Merged

Fixes reduced delivery of Brave ads campaigns with subdivision targeting - 1.32.x #10616

merged 1 commit into from
Oct 29, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 20, 2021 •
edited by kjozwiak
Loading

Uplift of #10551
Resolves brave/brave-browser#18748

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.32.x - Beta milestone Oct 20, 2021
@tmancey tmancey requested a review from a team October 20, 2021 16:17
@tmancey tmancey self-assigned this Oct 20, 2021
@tmancey tmancey changed the title Fixes reduced delivery of Brave ads campaigns with subdivision targeting Fixes reduced delivery of Brave ads campaigns with subdivision targeting - 1.32.x Oct 20, 2021
@tmancey tmancey force-pushed the issues/18748-1.32.x branch from 41cca4a to fed00ba Compare October 21, 2021 12:53
@kjozwiak
Copy link
Member

@tmancey looks all the platforms are failing due to the same issue. Mind taking a look?

 FAILED: obj/brave/vendor/bat-native-ads/ads/eligible_inline_content_ads.o 

 ../../brave/vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/inline_content_ads/eligible_inline_content_ads.cc:259:29: error: use of undeclared identifier 'creative_ads'
10:48:39        ShouldCapLastServedAd(creative_ads) ? last_served_creative_ad_ : AdInfo(),
10:48:39                              ^
10:48:39  1 error generated.

@kjozwiak
Copy link
Member

Adding PR/Blocked until the above is fixed. @tmancey once resolved, mind removing the PR/Blocked? Thanks!

@tmancey tmancey force-pushed the issues/18748-1.32.x branch from fed00ba to 9fc00f0 Compare October 22, 2021 14:21
@tmancey tmancey force-pushed the issues/18748-1.32.x branch from 9fc00f0 to 2bde035 Compare October 22, 2021 14:48
kjozwiak
kjozwiak approved these changes Oct 29, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.32.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10551 (comment).

@kjozwiak kjozwiak merged commit 88215b2 into 1.32.x Oct 29, 2021
@kjozwiak kjozwiak deleted the issues/18748-1.32.x branch October 29, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak