Skip to content

Go backwards on IPFS pages when automatic DNSLink redirection is enabled #10556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 16, 2021

Resolves brave/brave-browser#16557

  • Go backwards on IPFS pages when automatic DNSLink redirection is enabled

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable IPFS local node
  2. Enable the Automatically redirect to IPFS pages via DNSLink when possible setting
  3. Visit ipfs.io
  4. Click the Help link in the top right corner of the webpage
  5. Click the Back button in Brave.
  6. Notice that Brave goes back to the IPFS home page.

@spylogsster spylogsster requested a review from bbondy October 16, 2021 10:21
@spylogsster spylogsster self-assigned this Oct 16, 2021
@spylogsster spylogsster merged commit f79efc7 into master Oct 17, 2021
@spylogsster spylogsster deleted the issue-16557 branch October 17, 2021 06:05
@spylogsster spylogsster added this to the 1.33.x - Nightly milestone Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to go backwards on IPFS pages when automatic DNSLink redirection is enabled
2 participants