Enable hangouts extension to allow screen share #1983
Conversation
|
security review comment: please verify either manually or with the |
bbondy
changed the title
|
This is on hold until such a time that we add a switch for the ability to disable this in brave://extensions. |
bbondy
changed the title
|
Sorry for the delay, built and ran tests on all platforms. |
Enable hangouts extension to allow screen share
Enable hangouts extension to allow screen share
| @@ -49,6 +49,8 @@ const Config = function () { | |||
| this.sccache = getNPMConfig(['sccache']) | |||
| this.braveReferralsApiKey = getNPMConfig(['brave_referrals_api_key']) || '' | |||
| this.ignore_compile_failure = false | |||
| this.enable_hangout_services_extension = true | |||
There was a problem hiding this comment.
we should make sure that anything new we add here is android compatible. I'm guessing this needs to be !android
There was a problem hiding this comment.
good call, I'll start to consider android more. I'll fix in a follow up.
There was a problem hiding this comment.
Actually this can't be set yet because we don't have the android option landed yet. It'll have to go in in the branch where this is being added.
Fix #1982
Requires: brave/brave-core#1227
This can be reviewed at any time, but please wait for the security review before merging, and only if it is a successful security review would we merge:
https://github.com/brave/internal/issues/452
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: