Skip to content

Release notes for 1.29.x #17824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Conversation

kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Sep 2, 2021

Resolves #17823

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A

@kjozwiak kjozwiak added QA/No release-notes/exclude CI/skip OS/Android Fixes related to Android browser functionality labels Sep 2, 2021
@kjozwiak kjozwiak added this to the 1.29.x - Release milestone Sep 2, 2021
@kjozwiak kjozwiak self-assigned this Sep 2, 2021
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak kjozwiak merged commit c291833 into master Sep 2, 2021
@kjozwiak kjozwiak deleted the release-notes-1.29.x-release-android branch September 2, 2021 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release notes for 1.29.x - Release
3 participants