Skip to content

cleanup resources file handling #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2018
Merged

cleanup resources file handling #1418

merged 1 commit into from
Oct 5, 2018

Conversation

bridiver
Copy link
Contributor

@bridiver bridiver commented Oct 4, 2018

requires brave/brave-core#566
fix #1419

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bridiver bridiver self-assigned this Oct 4, 2018
@bridiver bridiver requested review from bbondy and yrliou October 4, 2018 01:40
@yrliou
Copy link
Member

yrliou commented Oct 4, 2018

Please also remove these copies in https://github.com/brave/brave-browser/blob/master/lib/util.js#L114-L117, and variables which become unused after you remove this.

Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bridiver bridiver merged commit 5096390 into master Oct 5, 2018
bridiver added a commit that referenced this pull request Oct 5, 2018
cleanup resources file handling
bridiver added a commit that referenced this pull request Oct 5, 2018
cleanup resources file handling
@NejcZdovc NejcZdovc deleted the resources-cleanup branch October 27, 2018 16:40
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@bbondy bbondy removed the 0.56.x label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify brave/chrome resource handling for patched files
3 participants