Skip to content

Fix 9365: Add gn check to npm scripts (Uplift 1.12.x) #10844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix 9365: Add gn check to npm scripts (Uplift 1.12.x) #10844

merged 2 commits into from
Jul 22, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Jul 22, 2020 •
edited by bsclifton
Loading

Uplift of #10599
Resolves : #9365

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@jumde jumde requested a review from a team July 22, 2020 03:26
@jumde jumde self-assigned this Jul 22, 2020
@jumde jumde force-pushed the gn_check_1.12.x branch from 3cdd619 to 8b2b0b4 Compare July 22, 2020 04:35
@jumde jumde force-pushed the gn_check_1.12.x branch from 8b2b0b4 to 21fd7ec Compare July 22, 2020 04:39
bsclifton
bsclifton approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

This was referenced Jul 22, 2020
Merged
Merged
@bsclifton bsclifton added this to the 1.12.x - Beta milestone Jul 22, 2020
@bsclifton bsclifton merged commit 9d31fd9 into 1.12.x Jul 22, 2020
@bsclifton bsclifton deleted the gn_check_1.12.x branch July 22, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@jumde @bsclifton