Can't load Twitter with 3rd party cookies blocked

[eljuno]

Description

Reported here https://community.brave.com/t/twitter-mobile-site-not-accessible/119865?u=eljuno

User unable to load Twitter.com if 3rd party cookies is blocked. Twitter showing "Something went wrong, Try again!” error message.

Loaded properly if 3rd party cookies blocker is disabled.

Steps to reproduce

1. Visit Twitter with default shield -- 3rd party cookies blocked
2. Twitter unable to load. "Something went wrong" error message
3. Disable 3rd party cookies blocker. Reload. Twitter loaded properly.

Actual result

https://drive.google.com/file/d/1OY6oAAIeRWdZYNjG6vTgV2xBGaJ4k_I3/view

Expected result

Twitter loaded properly with 3rd party cookies blocked

Issue reproduces how often

Easy on my end.

Issue happens on

• Current Play Store version? Yes
• Beta build? NDA

Device details

• Install type (ARM, x86): NDA
• Device (Phone, Tablet, Phablet): Redmi Note 5
• Android version: 9.0

Brave version

V.1.5.131

Website problems only

• Does the issue resolve itself when disabling Brave Shields? Yes. 3rd party cookies blocker disabled
• Does the issue resolve itself when disabling Brave Rewards? NDA
• Is the issue reproducible on the latest version of Chrome? NDA

Additional information

cc @SergeyZhukovsky @srirambv @samartnik

[samartnik]

Issue related to all OSes. To reproduce on desktop just set allow cookies for twitter first, then set cross-site cookies blocked.

[bridiver]

The default block 3rd-party cookies setting allows subdomains, but the site setting does not. The site settings should match the default setting and a PR will be ready soon

[kjozwiak]

Removed the OS/Android label as this still seems broken on Android as per brave/brave-core#5318 (comment), brave/brave-core#5318 (comment) and brave/brave-core#5318 (comment).

@jumde is taking a look on why it's still reproducible on Android and will create a follow up issue.

[btlechowski]

We need a new build for this one (1.8.85 does not contain the fix)

[btlechowski]

Verification passed on

Brave	1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
Revision	3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS	Ubuntu 18.04 LTS

Reproduced the issue on 1.7.98

Verified fixed after upgrade to 1.8.86

Also verified on clean profile

---

Verification PASSED on macOS 10.15.4 x64 Catalina using the following build:

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.15.4 (Build 19E287)

• ensured that the STR outlined via allow first party subdomains when blocking 3rd-party cookies to match… brave-core#5318 (comment) worked as expected.

Case #1 [New Profile]

• downloaded & installed 1.8.86 CR: 81.0.4044.129
• loaded https://twitter.com and selected All cookies allowed via shields
• logged into Twitter without any issues
• switched All cookies allowed to Cross-site cookies blocked and ensured Twitter loads
• switched between All cookies allowed & Cross-site cookies blocked several times

Case #1 [Update]

• downloaded & installed 1.7.98 CR: 81.0.4044.113
• loaded https://twitter.com and selected All cookies allowed via shields
• logged into Twitter without any issues
• switched All cookies allowed to Cross-site cookies blocked and ensured and reproduced the original issue as per the following example:

• upgraded to 1.8.86 CR: 81.0.4044.129 and ensured that the above issue isn't reproducible
• switched between All cookies allowed & Cross-site cookies blocked several times

Verification passed on

Brave | 1.8.86 Chromium: 81.0.4044.129 (Official Build) (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Reproduced the issue in 1.7.98

Upgrade the same profile to 1.8.86 fixed the issue.

• Ensured that the STR outlined via allow first party subdomains when blocking 3rd-party cookies to match… brave-core#5318 (comment) worked as expected.
• Verified both clean and upgraded profiles