Add clear rewards data and clear payment data

[NejcZdovc]

User should be able to remove rewards data (auto contribute, donation, tipping) and remove payment data (previous payments). This should delete the data on disk.

From browser laptop

[diracdeltas]

Marking this as p3 and privacy related because currently there is no way to delete browsing history associated with rewards unless the user deletes the files on disk. if rewards is enabled, browsing history is logged to publisher_info_db. @NejcZdovc please correct me if i'm wrong.

cc @tomlowenthal

[tildelowengrimm]

I think the right solution would be to extend brave://settings/clearBrowserData to include controls for Brave Rewards.

For the simply view, we should add a "Brave Rewards data" item which removes all attention info created from the indicated time period.

On the advanced tab, we should add a couple of items.

• "Brave Rewards auto-contribute list" should remove attention history and auto-contribute items for the applicable time period.
• "Brave Rewards contribution history" should remove records of tips and contributions from the time period, replacing them with "private contribution" or something to that effect.

@mandar-brave @NejcZdovc Could someone on the Rewards team indicate whether there are any other ways that information equivalent to browsing-history might be stored?

[jasonrsadler]

What is defined as "applicable time period"? Currently we store auto-contribute information based on month and year. The options available when clearing data are "last hour", "last 24 hours", "last 7 days", and "last 4 weeks". How should we handle clearing data based on what is chosen?

[tildelowengrimm]

@jasonrsadler Are you saying that we have no way of knowing what auto-contribute info was added in the last hour, the last 24 hours, or last 7 days?

[jasonrsadler]

Correct. @NejcZdovc to confirm but I believe we are only storing the month and the year.

[NejcZdovc]

@tomlowenthal that is correct we accumulate time per month and not per visit

[tildelowengrimm]

Sounds like we'll need to change that in order to be able to support deletion.

[diracdeltas]

Personally I would be happy if someone just added an option for "Clear Brave rewards and payment data since the beginning of time".

Having time intervals can be a follow-up but I don't think it's strictly necessary (we didn't have this in b-l)

[NejcZdovc]

I think we shouldn't change it. We should adjust place where we have clear like @diracdeltas said

[tildelowengrimm]

I think we should do both, but I'm okay with only having "from the beginning of time" as a first pass.

Brave Rewards is basically another browser history repository separate from the regular browser history. People should have at least the same degree of transparency and control that they have over their regular browser history.

Those time intervals are really useful tools. Let's say I open a regular tab instead of a private one, and browse for a minute before realizing my mistake. That's what "from the last hour" is for, and it's a valuable feature. I shouldn't have to blow away my entire auto-contribute list to do this.

[mandar-brave]

@tomlowenthal let's discuss the time based ask on the product meeting - worth a debate. Considering the data, unlike browsing or bookmarks, is not very usable as such it's not clear to me that a time-based approach is needed but let's open it to @rebron as well.

@jasonrsadler for now, the options you have presented

• Delete all-time auto-contribute
• Delete all-time Rewards (Should remove all ledger data incl. auto-contribute, recurring tips, tips, statements, and current in-wallet transactions)

are fine.

However, the wallet and the wallet balance remain intact.

cc @NejcZdovc

[rebron]

@mkarolin @jasonrsadler @bradleyrichter @mandar-brave making sure this one is on your radar as well. #492
Need decision if we want these options for clear on exit as well.

[tildelowengrimm]

If you're going to clear auto-contribute on exit, you'd be better-off just not enabling that feature.

[jasonrsadler]

👍 @tomlowenthal.

Per slack convo, I think #492 uses a different tab and shouldn't have rewards included. Either let the user explicitly clear rewards, or if they want it cleared on exit, just disable.

[jasonrsadler]

Per convo with @bridiver, updating requirements defined so far:

1. Allow clearing auto-contribute list in Rewards.

2. Allow clearing all Rewards data (minus wallet).

3. If contribution is in progress, either just clear OR disable clear OR show warning

[jasonrsadler]

cc @davidtemkin and @mandar-brave
How should # 3 in above comment above be handled?

[NejcZdovc]

closing as this will be implemented in #10064

[LaurenWags]

Verified passed with

Brave | 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Adds UI to clear browsing data flow brave-core#6020
• Confirmed link exists on each Clear browsing data tab:

• Confirmed clicking on the link from each tab opens the Manage Your Wallet dialog

• Confirmed link displays using light theme also:

• Encountered [Desktop] Restore modal window shows error before entering keys #11235 while testing

---

Verification passed on

Brave	1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
Revision	d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS	Ubuntu 18.04 LTS

• Verified test plan from Adds UI to clear browsing data flow brave-core#6020

• Confirmed link exists on each Clear browsing data tab(brave://settings/clearBrowserData) :
  Dark theme
  
  
  
  Light Theme
  

• Confirmed clicking on the link from each tab opens the Manage Your Wallet dialog
  

Encountered #11235
Logged #11244

---

Verification passed on

Brave | 1.13.73 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

• Verified test plan from Adds UI to clear browsing data flow brave-core#6020
• Confirmed link exists on each Clear browsing data tab:

Basic View:

Advanced view:

On exit:

• Confirmed clicking on the link from each tab opens the Manage Your Wallet dialog
  

• Confirmed link displays using Dark theme also:
  

-Encountered #11235
-Verified Reset wallet works as expected