Skip to content

[Android] Replace desktop icon with Mobile icon for devices list #7359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Oct 22, 2018 · 7 comments · Fixed by brave/brave-core#25464
Closed

[Android] Replace desktop icon with Mobile icon for devices list #7359

srirambv opened this issue Oct 22, 2018 · 7 comments · Fixed by brave/brave-core#25464
Assignees
@deeppandya
Labels
design A design change, especially one which needs input from the design team feature/sync OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.71.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 22, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#25464

Description

Remove desktop icon with Mobile icon for devices list

Device Details

  • Install Type(ARM, x86): All
  • Device(Phone, Tablet, Phablet): All
  • Android Version: All

Actual Behavior

image
@anthonypkeane anthonypkeane transferred this issue from another repository Dec 12, 2019
@srirambv srirambv added OS/Android Fixes related to Android browser functionality design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/sync labels Dec 12, 2019
@jsecretan jsecretan added the priority/P4 Planned work. We expect to get to it "soon". label Aug 25, 2020
@srirambv srirambv changed the title Remove desktop icon with Mobile icon for devices list [Android] Remove desktop icon with Mobile icon for devices list Sep 9, 2020
@AlexeyBarabash
Copy link
Contributor

Yes, can reproduce, thanks for finding this @srirambv .

@rebron rebron moved this to P3, P4, & P5 backlog in Sync - All platforms Jul 23, 2024
@bsclifton
Copy link
Member

Updated assignment - @bradleyrichter @aguscruiz, this could be a good one 😄

Would be a nice touch to have a mobile icon for Android and iOS

@aguscruiz
Copy link

In Nala icons we have:

smartphone
image

laptop
image

monitor
image

We can use those

@bsclifton bsclifton added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Sep 4, 2024
@deeppandya
Copy link
Contributor

deeppandya commented Sep 6, 2024 •
edited
Loading

@aguscruiz we have 3 types for device. phone, tablet, desktop/laptop
for phone, i am using smartphone
for tablet, i am using tablet
for desktop/laptop, i am using monitor
Please let me know if i should change anything

@deeppandya deeppandya mentioned this issue Sep 6, 2024
Merged
24 tasks
@aguscruiz
Copy link

Ah ok, phone and tablet great, for desktop/laptop, I'd use laptop instead.

@bsclifton bsclifton changed the title [Android] Remove desktop icon with Mobile icon for devices list [Android] Replace desktop icon with Mobile icon for devices list Sep 6, 2024
@github-project-automation github-project-automation bot moved this from P3, P4, & P5 backlog to Completed in Sync - All platforms Sep 6, 2024
@bsclifton bsclifton added this to the 1.71.x - Nightly milestone Sep 6, 2024
@deeppandya deeppandya mentioned this issue Sep 9, 2024
Closed
@deeppandya
Copy link
Contributor

Ah ok, phone and tablet great, for desktop/laptop, I'd use laptop instead.

@aguscruiz Addressing the change here : #40936

@srirambv
Copy link
Contributor Author

srirambv commented Oct 8, 2024

Verification passed on the following devices running 1.71.104 x64 Beta build

  • Verified steps from brave/brave-core#25464
  • Verified Mobile devices on Sync chain has mobile icons
  • Verified Tablet devices on Sync chain has tablet icons
  • Verified Desktop devices on Sync chain has Desktop icon
Google Pixel 8 (Android 14) Lenovo Tab (Android 14)

@hffvld hffvld mentioned this issue Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
design A design change, especially one which needs input from the design team feature/sync OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Sync - All platforms
Status: Completed
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Update icons for device types in brave sync brave/brave-core
8 participants
@jamesmudgett @jsecretan @bsclifton @deeppandya @bradleyrichter @aguscruiz @srirambv @AlexeyBarabash