Skip to content

[Android] Replace desktop icon with laptop icon for desktop/laptop device #40936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deeppandya opened this issue Sep 9, 2024 · 1 comment · Fixed by brave/brave-core#25939
Closed

[Android] Replace desktop icon with laptop icon for desktop/laptop device #40936

deeppandya opened this issue Sep 9, 2024 · 1 comment · Fixed by brave/brave-core#25939
Assignees
@deeppandya
Labels
feature/sync OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.74.x - Release

Comments

@deeppandya
Copy link
Contributor

This issue is to update desktop/laptop icon as a follow up of #7359 based on #7359 (comment)
@deeppandya deeppandya added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Sep 9, 2024
@deeppandya deeppandya self-assigned this Sep 9, 2024
@deeppandya deeppandya mentioned this issue Sep 9, 2024
Closed
@deeppandya deeppandya mentioned this issue Oct 10, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.73.x - Nightly milestone Oct 10, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Nov 22, 2024
@hffvld
Copy link
Contributor

hffvld commented Nov 22, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 15 AP41.240925.009 release-keys
Brave build: 1.74.8 
Chromium: 131.0.6778.69 (Official Build) beta (64-bit)

STEPS:

  1. Follow the STR/TP from Update laptop icon for sync brave-core#25939 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that phones (Android and iOS) have the Phone thumbnail in the Sync chain.
  • Verified that tablets (Android and iPadOS) have the Tablet thumbnail in the Sync chain.
  • Verified that computers (Desktop and Laptop) have the Laptop thumbnail in the Sync chain.

NOTE: Tablets have a wrong thumbnail in the Send to your devices bottom-sheet modal - #41413.

1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/sync OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.74.x - Release
Development

Successfully merging a pull request may close this issue.

Update laptop icon for sync brave/brave-core
4 participants
@kjozwiak @deeppandya @brave-builds @hffvld