Skip to content

Command line doesn't URL-encode spaces in its arguments #7079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lokegustafsson opened this issue Nov 24, 2019 · 0 comments
Open

Command line doesn't URL-encode spaces in its arguments #7079

lokegustafsson opened this issue Nov 24, 2019 · 0 comments
Labels
OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@lokegustafsson
Copy link

Description

As said in the title, opening a pdf through the command line fails when the file name contains spaces. Instead of one tab with file:///home/loke/my%20file.pdf, one tab opens with file:///home/loke/my and another with file.pdf.

Steps to Reproduce

  1. Use Linux? I am not sure about non-Linux equivalents to the command line brave
  2. Locate some file on your system, here /home/loke/my file.pdf.
  3. Execute and compare brave "file:///home/loke/my file.pdf" and brave "file:///home/loke/my%20file.pdf"

Actual result:

brave "file:///home/loke/my file.pdf" opens two tabs, file:///home/loke/my and file.pdf.
brave "file:///home/loke/my%20file.pdf" opens a single tab, file:///home/loke/my%20file.pdf.

Expected result:

I think that the first command should behave the same as the second one, that spaces in an argument should be automatically URL-encoded.

Reproduces how often:

This occurs every single time.

Brave version (brave://version info)

Brave | 0.69.132 Chromium: 77.0.3865.90 (Official Build) unknown (64-bit)
Revision | 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS | Linux
(arch linux)

@rebron rebron added priority/P5 Not scheduled. Don't anticipate work on this any time soon. OS/Linux labels Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

2 participants