Skip to content

Add refresh status to connected publisher #5964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeetaSarvadnya opened this issue Sep 10, 2019 · 2 comments · Fixed by brave/brave-core#4010
Closed

Add refresh status to connected publisher #5964

GeetaSarvadnya opened this issue Sep 10, 2019 · 2 comments · Fixed by brave/brave-core#4010

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 10, 2019

Description

Add refresh status to connected publisher

Steps to Reproduce

  1. Staging profile 0.69.124
  2. Enable rewards and connect existing fully KYC'd staging uphold wallet
  3. Open staging publisher website
  4. Connect fully KYC'd uphold account to your publisher account
  5. Open any of your channel which was added in publisher account
  6. Click on BR panel, panel shows the publisher is not KYC'd

Actual result:

Verified publisher list is NOT pulled when KYC'd uphold is connected to the publisher account
image (2)

Expected result:

Discussed with @NejcZdovc
@NejcZdovc is going to introduce Refresh button in the panel to get the latest pubs list

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @NejcZdovc @mandar-brave

@NejcZdovc
Copy link
Contributor

this is not related to publisher status. Thing is that your list was not updated yet. What we need to do is to add refresh status option for connected publishers as well.

@NejcZdovc NejcZdovc changed the title Verified publisher list is NOT pulled when KYC'd uphold is connected to the publisher account Add refresh status to connected publisher Sep 10, 2019
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 12, 2019
ryanml added a commit to brave/brave-core that referenced this issue Nov 27, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Nov 28, 2019
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 28, 2019
@btlechowski
Copy link

btlechowski commented Jan 14, 2020

Verification passed on

Brave 1.3.90 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS

Verified test plan from the description. Refresh status was added to the connected publisher. Clicking on the Refresh status button re-downloads whole publisher list from the server.

image

When publisher becomes fully verified, the status is reflected in the Rewards Panel
image

Verified passed with

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)
  • Confirmed that connected (not KYC'd) publishers show the 'Refresh status' link on the panel:

Screen Shot 2020-01-14 at 5 45 50 PM

  • After link is selected, publisher list is refreshed:

Screen Shot 2020-01-14 at 5 46 02 PM

Verification passed on

Brave 1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description. Refresh status was added to the connected publisher. Clicking on the Refresh status button re-downloads the whole publisher list from the server.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants