Add to Chrome on CWS main page

[btlechowski]

Follow up to #790

Steps to Reproduce

1. Open https://chrome.google.com/webstore/category/extensions

Actual result:

Add to Chrome on CWS main page

Expected result:

Add to Brave on CWS main page

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave	0.69.110 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision	ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS	Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron

[bsclifton]

Functionality originally fixed with brave/brave-core#2845

Looks like it regressed completely (at least on Nightly)... content script has correct selector still

[bsclifton]

Ah - if you refresh after going to a detail page, it then executes the content script properly (weird that a refresh is needed though). Also, directly navigating to a detail page works fine, as expected

This issue (hover showing Add to Chrome) can be fixed by adding https://chrome.google.com/webstore/category/extensions (or a better selector) to the manifest.json here:
https://github.com/brave/brave-core/blob/05c7b6199273870ecc536798a0f223c5f2d5794d/components/brave_extension/extension/brave_extension/manifest.json#L36-L38

[LaurenWags]

Reproduced originally described issue as well as issue described with #5730 (comment)

Brave	0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision	fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS	Mac OS X

And after page refresh:

[eljuno]

+1 from Community https://community.brave.com/t/chrome-web-store-still-displaying-add-to-chrome/86046?u=eljuno

[kjozwiak]

@rebron @bsclifton looks like this regressed again. Originally it was fixed via #790 and checked by QA via the following verifications #790 (comment).

I also checked and reproduced using 0.69.119 Chromium: 76.0.3809.132 which was originally used for verification as per #790 (comment). Definitely seems like something was changed on Google's side.

CCing @brave/legacy_qa so they're aware of the issue.

[btlechowski]

Verification passed on

Brave	1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4013 and from the description
Verified extensions main page and individual extension pages.

Verification passed on

Brave	1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Update pattern for Add to Brave content script brave-core#4013 and from the description
• Verified extensions' main page and individual extension pages.
  
  
  
  
  

Verified passed with

Brave	1.3.88 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.14.6 (Build 18G103)

• Verified test plan from Update pattern for Add to Brave content script brave-core#4013 and description

Extensions Main page (hover over image at top)

Individual extension page before adding:

Individual extension page after adding:

Searching for extensions: