Skip to content

WebTorrent: Stats remain stuck after download finishes #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feross opened this issue Jul 23, 2019 · 1 comment · Fixed by brave/brave-core#3004
Closed

WebTorrent: Stats remain stuck after download finishes #5352

feross opened this issue Jul 23, 2019 · 1 comment · Fixed by brave/brave-core#3004

Comments

@feross
Copy link

feross commented Jul 23, 2019

Description

When a torrent finishes, the stats stop updating and stay stuck on the last state, which may show that e.g. there's still a download rate of 2.4 MB/s (when in fact the download rate is 0 MB/s) as can be seen here:

Screen Shot 2019-07-23 at 1 16 19 PM

Steps to Reproduce

  1. Visit https://webtorrent.io/free-torrents
  2. Click Big Buck Bunny (torrent file)
  3. Start torrent download
  4. Wait for the download to complete and look at the stats

Actual result:

Stats freeze

Expected result:

Stats continue updating when download is complete

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@feross feross added the feature/webtorrent Label for webtorrent related issues label Jul 23, 2019
@feross feross self-assigned this Jul 23, 2019
feross added a commit to brave/brave-core that referenced this issue Jul 25, 2019
Fixes: brave/brave-browser#5352

- Always update stats at least once every 5 seconds, even when no torrent events fire
- remove stray console logs
- Listen for 'wire' (new peer) events
- Listen for 'done' event
feross added a commit to brave/brave-core that referenced this issue Jul 26, 2019
Fixes: brave/brave-browser#5352

- Always update stats at least once every 5 seconds, even when no torrent events fire
- remove stray console logs
- Listen for 'wire' (new peer) events
- Listen for 'done' event
@yrliou yrliou added this to the 0.70.x - Nightly milestone Jul 27, 2019
@btlechowski
Copy link

btlechowski commented Sep 18, 2019

Verification passed on

Brave 0.70.96 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3004

image

Verificationn passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.126 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-18 at 12 19 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment