Skip to content

Use correct profile for Wallet classes #45937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6 tasks
samartnik opened this issue May 8, 2025 · 0 comments
Open
6 tasks

Use correct profile for Wallet classes #45937

samartnik opened this issue May 8, 2025 · 0 comments
Labels
OS/Android Fixes related to Android browser functionality

Comments

@samartnik
Copy link
Contributor

Description

We should remove Utils.getProfile and pass proper profile for Wallet classes and everywhere else where this function is used at the moment.

Steps to reproduce

No steps, but developer should identify what needs to be rechecked after the changes.

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version

n/a

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label May 8, 2025
samartnik added a commit to brave/brave-core that referenced this issue May 8, 2025
This function should be removed and proper profile should be passed brave/brave-browser#45937
mkarolin pushed a commit to brave/brave-core that referenced this issue May 12, 2025
This function should be removed and proper profile should be passed brave/brave-browser#45937
samartnik added a commit to brave/brave-core that referenced this issue May 12, 2025
This function should be removed and proper profile should be passed brave/brave-browser#45937
samartnik added a commit to brave/brave-core that referenced this issue May 12, 2025
This function should be removed and proper profile should be passed brave/brave-browser#45937
mkarolin pushed a commit to brave/brave-core that referenced this issue May 12, 2025
This function should be removed and proper profile should be passed brave/brave-browser#45937
mkarolin pushed a commit to brave/brave-core that referenced this issue May 13, 2025
This function should be removed and proper profile should be passed brave/brave-browser#45937
mkarolin pushed a commit to brave/brave-core that referenced this issue May 13, 2025
This function should be removed and proper profile should be passed brave/brave-browser#45937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

1 participant