Open in new private window results in normal window

[warwickmm]

Description

When Private Browsing Only is enabled, opening a link using "Open in New Private Window" opens it in a normal (non-private) window.

Steps to reproduce

1. Turn on Private Browsing Only.
2. Visit some page with links.
3. Long press a link and select "Open in New Private Window".
4. Observe that the link opens in a normal window (judging by its appearance). In the new window, the history is available, which further indicates that it is not a private window.

Actual result

compressed.mp4

Expected result

The new window should be in private mode.

Reproduces how often

Easily reproduced

Brave version

1.76 (77)
BaveCore 1.76.77 (134.0.6998.95)

Device/iOS version

iPad Air (5th generation)
iPadOS 18.3.2

Affected browser versions

• latest AppStore
• latest TestFlight
• previous TestFlight

Reproducibility

• with Brave Shields disabled
• in the latest version of mobile Safari

Miscellaneous information

No response

[kjozwiak]

The above requires 1.78.85 or higher for 1.78.x verification 👍

[Uni-verse]

Verified on iPad (9th Gen) running iOS 18.3.1 using version 1.78.90

• Reproduced the original issue on an earlier build, then installed 1.78.90, enabled Private Browsing Only and used test steps in Open in new private window results in normal window #45389 (comment) to ensure the following:
  • Link are opened in a new private window when using "Open in New Private Window" from the context menu.
  • Windows are successfully opening in Private mode in both portrait and landscape orientation.
  • Private tabs can be opened/loaded in the background and also from the toolbar.
  • When in normal browsing mode, selecting Open in New Private Window will launch new private window successfully

example	example	example