Skip to content

Crash when clicking on sidebar with video playing in PiP #45144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue Apr 2, 2025 · 4 comments · Fixed by brave/brave-core#28485
Closed

Crash when clicking on sidebar with video playing in PiP #45144

srirambv opened this issue Apr 2, 2025 · 4 comments · Fixed by brave/brave-core#28485

Comments

@srirambv
Copy link
Contributor

srirambv commented Apr 2, 2025

IMPORTANT: Your crash has already been automatically reported to our crash system. Please file this bug only if you can provide more information about it.

Brave Version: 1.78.69 Chromium: 135.0.7049.28
Operating System: Mac OS X 15.3.2

URL (if applicable) where crash occurred:

Can you reproduce this crash?

What steps will reproduce this crash? (If it's not reproducible, what were you doing just before the crash?)

  1. Add a video into playlist
  2. Play the media
  3. Hide the sidebar so the media continues to play
  4. Click on the side bar button
  5. Browser crashes

DO NOT CHANGE BELOW THIS LINE
Crash ID: crash/2f141c00-394b-9a0d-0000-000000000000

Miscellaneous Info

cc: @iefremov @brave/legacy_qa @rebron @simonhong

@Ilie-Lesan
Copy link

The code checks here:
Image

And the upstream commit where the issue was introduced is here:
https://chromium-review.googlesource.com/c/chromium/src/+/6196974

@simonhong simonhong self-assigned this Apr 3, 2025
@simonhong
Copy link
Member

@Ilie-Lesan Thanks for the info! 👍🏼

@MadhaviSeelam
Copy link

MadhaviSeelam commented May 1, 2025

Verification PASSED using

Brave | 1.79.97 Chromium: 136.0.7103.60 (Official Build) beta (64-bit)
-- | --
Revision | a1f11441d408f4f9662f1a56d93aa2c0d139f5b0
OS | Windows 11 Version 24H2 (Build 26100.3775)

Filed a follow up

Image

@srirambv
Copy link
Contributor Author

srirambv commented May 5, 2025

Verification passed on

Brave 1.79.97 Chromium: 136.0.7103.60 (Official Build) beta (64-bit)
Revision a1f11441d408f4f9662f1a56d93aa2c0d139f5b0
OS Windows 11 Version 24H2 (Build 26100.3775)
  • Verified steps from issue description
  • Verified able to add media to playlist
  • Verified no crash when opening sidebar while media is playing
  • Verified no crash even when media is playing in minimized view
45144.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants