Skip to content

Update brave://settings header #43718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 6 tasks
rebron opened this issue Feb 4, 2025 · 3 comments · Fixed by brave/brave-core#27538
Closed
3 of 6 tasks

Update brave://settings header #43718

rebron opened this issue Feb 4, 2025 · 3 comments · Fixed by brave/brave-core#27538
Assignees
@aguscruiz
Labels
feature/settings good first issue OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.77.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Feb 4, 2025

Description

In brave://settings, we can tighten up the header by removing Brave from Brave Rewards and update the ordering to:
History | Bookmarks | Downloads | Wallet | Rewards

See Expected vs Actual result screenshots.

Steps to reproduce

  1. Got to brave://settings
  2. Notice header

Actual result

Image

Expected result

Image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Target release tbd.

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added OS/Desktop feature/settings polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include labels Feb 4, 2025
@rebron rebron changed the title Update header for settings Update brave://settings header Feb 4, 2025
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". good first issue labels Feb 4, 2025
@rebron rebron moved this to P4 backlog in Settings Feb 4, 2025
@celin07
Copy link

celin07 commented Feb 4, 2025 •
edited
Loading

Can i work on this?

@aguscruiz aguscruiz self-assigned this Feb 6, 2025
@aguscruiz aguscruiz mentioned this issue Feb 6, 2025
Merged
24 tasks
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Feb 7, 2025
@rebron
Copy link
Collaborator Author

rebron commented Feb 7, 2025

Can i work on this?

Hi @celin07 We'll find another one for you. This one was a little too easy for us to fix.

@rebron rebron moved this from P4 backlog to Completed in Settings Feb 7, 2025
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 5, 2025 •
edited
Loading

Verification PASSED using

Brave | 1.77.74 Chromium: 134.0.6998.39 (Official Build) beta (64-bit)
-- | --
Revision | 0c0752120db1810825ddb13dc5e7423eb0385f72
OS | Windows 11 Version 24H2 (Build 26100.3194)

Verified using the STR from issue description #43718 (comment)

Confirmed Rewards is displayed in the brave://settings header and re-ordered to show at the end after Wallet menu

Light Dark
Image Image
Image Image

@rebron rebron removed this from Settings Mar 28, 2025
@LaurenWags LaurenWags mentioned this issue Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aguscruiz aguscruiz

Labels
feature/settings good first issue OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.77.x - Release
Development

Successfully merging a pull request may close this issue.

Reorder Settings top bar and rename Brave Rewards to Rewards brave/brave-core
5 participants
@rebron @aguscruiz @brave-builds @celin07 @MadhaviSeelam