Skip to content

Can't resize sidebar panels properly #43507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 of 6 tasks
aguscruiz opened this issue Jan 27, 2025 · 5 comments · Fixed by brave/brave-core#27841
Closed
3 of 6 tasks

Can't resize sidebar panels properly #43507

aguscruiz opened this issue Jan 27, 2025 · 5 comments · Fixed by brave/brave-core#27841
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS-arm64 QA/Yes release-notes/include
Milestone
1.77.x - Release

Comments

@aguscruiz
Copy link

Description

I'm having an issue with the sidebar panels. It's super weird, but I can almost never resize them. I get the <--> cursor maybe once, I resize it, and then it never appears again. I tried and it's happening in stable and nightly.
It happens wether I have the flag for spacing #brave-web-view-rounded-corners enabled or not.

Screen.Recording.2025-01-27.at.14.22.14.mov

Steps to reproduce

  1. Open a sidebar panel, like Leo
  2. Resize it
  3. Notice that once you resize you can't easily resize again

Actual result

Expected result

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.76.37 Chromium: 132.0.6834.111 (Official Build) nightly (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@kjozwiak kjozwiak added QA/Yes feature/sidebar Relating to Brave's Sidebar feature labels Jan 28, 2025
@simonhong simonhong self-assigned this Jan 31, 2025
@simonhong
Copy link
Member

This seems macOS specific. Can't repro this on Windows.

@rebron
Copy link
Collaborator

rebron commented Jan 31, 2025

It's possible to resize it's just that <--> doesn't show up consistently on hover.

@rebron rebron moved this to On Deck in Front End Feb 10, 2025
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 10, 2025
@rebron rebron mentioned this issue Feb 10, 2025
Closed
6 tasks
@rebron rebron removed their assignment Feb 25, 2025
@LaurenWags
Copy link
Member

Not able to reproduce with

Brave | 1.77.64 Chromium: 134.0.6998.24 (Official Build) nightly (x86_64)
-- | --
Revision | 0d8dca4c634de72e973731be2df712603e657373
OS | macOS Version 14.7.4 (Build 23H420)
Screen.Recording.2025-02-25.at.2.18.10.PM.mov

simonhong added a commit to brave/brave-core that referenced this issue Feb 27, 2025
@simonhong
Fixed cursor is not changed to resize when hovered to sidebar resize …
3e9b099 
…area

fix brave/brave-browser#43507

On macOS, previous cursor is not cleared when mouse goes out.
So, we can see resize cursor only once. To fix, clear current cursor
manually. Widget doesn't change its current cursor if it's same with
requested one.
simonhong added a commit to brave/brave-core that referenced this issue Feb 27, 2025
@simonhong
Fixed cursor is not changed to resize when hovered to sidebar resize …
f9d9a72 
…area

fix brave/brave-browser#43507

On macOS, previous cursor is not cleared when mouse goes out.
So, we can see resize cursor only once. To fix, clear current cursor
manually. Widget doesn't change its current cursor if it's same with
requested one.
@simonhong simonhong mentioned this issue Feb 27, 2025
Merged
24 tasks
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Feb 27, 2025
@rebron rebron moved this from On Deck to Completed in Front End Feb 27, 2025
@brave-builds brave-builds mentioned this issue Mar 4, 2025
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Mar 5, 2025

The above requires 1.77.75 or higher for 1.77.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 7, 2025 •
edited
Loading

Verification PASSED using

Brave | 1.77.75 Chromium: 134.0.6998.45 (Official Build) beta (arm64)
-- | --
Revision | 48fcf82fb7cf2a2142388c4b3179ff0215971fc3
OS | macOS Version 15.3.1 (Build 24D70)

Verified using the STR from issue description #43507 (comment)

Confirmed able to the resize the sidebar panels with the resize sidebar handle (<-->). However, when hovered over, the handle doesn't appear consistently specifically with fresh profile.

Screen.Recording.2025-03-07.at.12.04.57.PM.mov

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 7, 2025
@MadhaviSeelam MadhaviSeelam mentioned this issue Mar 7, 2025
Open
6 tasks
@MadhaviSeelam MadhaviSeelam added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 7, 2025
@rebron rebron removed this from Front End Mar 31, 2025
@LaurenWags LaurenWags mentioned this issue Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop OS/macOS priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS-arm64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.77.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed cursor is not changed to resize when hovered to sidebar resize area brave/brave-core
7 participants
@kjozwiak @rebron @simonhong @aguscruiz @LaurenWags @brave-builds @MadhaviSeelam