AI Chat conversations should persist browser restart #42800

petemill · 2024-12-10T21:11:02Z

We should implement an encrypted database for AI Chat conversations

Test Plan

(A) Conversations and all data persists after browser restart

Make the following conversations:

Conversation without content

Make a conversation in Leo not attached to content (toggle is disabled)
Add an entry to the conversation and wait for the response to complete

Conversation with content

Make a conversation in Leo not attached to content (toggle is enabled)
Add an entry to the conversation and wait for the response to complete

Restart the browser
Verify all conversations are available in Leo.
Verify the conversation with content shows the favicon and title for the conversation
Verify the conversations can be continued
Verify the conversation with content continues to use the last version of the content. Ask it a question it shouldn't know.

(B) Browsing Data deletion

Regular browsing data

Go to brave.com.
Open Leo sidebar and summarize the page and wait for the response to complete.
Verify you see the brave.com favicon and page title on top of the conversations.
Expand the Conversation to full-page
Close the brave.com Tab (otherwise the Conversation will get the data from the alive Tab again)
Go to brave://settings/clearBrowserData and use the "Basic" tab to delete "browsing history" for "all time". Click "Delete data" button and wait to complete.
Go back to the Leo full-page tab, and verify that the opened conversation does not show the brave.com favicon or page title, but that the conversation data is still there.
Restart the browser
Verify step 9. again

(C) Leo Data deletion

Create multiple conversations from both Sidebar and full-page Leo (chrome://leo-ai)
Close all sidebars and Leo full-page tabs
Go to brave://settings/clearBrowserData and use the "Advanced" tab to delete "Leo AI" for "all time". Click "Delete data" button and wait to complete.
Go back to chrome://leo-ai and verify all conversations are not there
Restart the browser
Verify step 3. again

The text was updated successfully, but these errors were encountered:

- [AIChat conversation data storage by petemill · Pull Request \#25876 · brave/brave-core](#25876) - [AI Chat conversations should persist browser restart · Issue \#42800 · brave/brave-browser](brave/brave-browser#42800) `QA/Yes` - [\[AIChat\]: Add URL based routing for different chats by fallaciousreasoning · Pull Request \#26050 · brave/brave-core](#26050) - [\[AI Chat\]: URLs for all conversations · Issue \#42055 · brave/brave-browser](brave/brave-browser#42055) `QA/Yes` - test plan: url and header variations specified - [AI Chat fullpage UI notices and polish by petemill · Pull Request \#26678 · brave/brave-core](#26678) - [AI Chat conversation list should prompt to enable history storage if it's disabled · Issue \#42576 · brave/brave-browser](brave/brave-browser#42576) `QA/Yes` - test plan: specified - [AI Chat notice for conversation storage · Issue \#42360 · brave/brave-browser](brave/brave-browser#42360) `QA/Yes` - test plan: specified - [AI Chat FullPage shouldn't show in SidePanel mode when restored at startup · Issue \#42413 · brave/brave-browser](brave/brave-browser#42413) `QA/Yes` - test plan: specified - [AI Chat becomes a trusted WebUI with an UntrustedWebUI frame for LLM-generated responses by petemill · Pull Request \#26855 · brave/brave-core](#26855) - [Change AI Chat url to chrome://leo-ai · Issue \#42817 · brave/brave-browser](brave/brave-browser#42817) `QA/Yes` - [AI Chat conversation entries should be isolated in an untrusted frame · Issue \#42818 · brave/brave-browser](brave/brave-browser#42818) `QA/No` - [\[AI Chat\]: Update copy button label by fallaciousreasoning · Pull Request \#26422 · brave/brave-core](#26422) - [Change copy button name to text if text in code block · Issue \#42117 · brave/brave-browser](brave/brave-browser#42117) `QA/Yes` - [\[AI Chat\]: Conversation starter pack, for unassociated content by fallaciousreasoning · Pull Request \#26379 · brave/brave-core](#26379) - [\[AI Chat\]: Add support for static conversation starters · Issue \#42106 · brave/brave-browser](brave/brave-browser#42106) `QA/Yes` - test plan: needs improvement - [Css tweaks and icon change for sidebar by aguscruiz · Pull Request \#26450 · brave/brave-core](#26450) - [\[Leo full page\] - Tweak to expand/collapse sidebar icons · Issue \#42068 · brave/brave-browser](brave/brave-browser#42068) `QA/Yes` - test plan: specified (check icons are correct) - [\[AI Chat\]: Update styling on suggestions by fallaciousreasoning · Pull Request \#26565 · brave/brave-core](#26565) - [\[AI Chat\]: Update suggestions style to match new design · Issue \#42107 · brave/brave-browser](brave/brave-browser#42107) `QA/Yes` - test plan: specified (check suggestions have new style) - [\[AI Chat\]: Don't show starter suggestions on non-empty chats by fallaciousreasoning · Pull Request \#26677 · brave/brave-core](#26677) - [AI Chat static conversation starters shouldn't show if conversation has chat history · Issue \#42412 · brave/brave-browser](brave/brave-browser#42412) `QA/Yes` - test plan: specified (verify conversation starters only show when applicable) - [fix hit area for leo conversations list by aguscruiz · Pull Request \#26793 · brave/brave-core](#26793) - [Leo full page - Conversation list - Make the whole item clickable instead of excluding the padding · Issue \#42552 · brave/brave-browser](brave/brave-browser#42552) `QA/No` - [\[Nala / @brave/leo\] update dependency by petemill · Pull Request \#26767 · brave/brave-core](#26767) - brave/brave-browser#42545 `QA/No`

srirambv · 2025-01-21T09:06:25Z

Verification passed on

Brave	1.75.162 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
Revision	1c01fd7f190ad7c9c88cb964f55e35400bf399ae
OS	Windows 11 Version 24H2 (Build 26100.2894)

Verified steps from issue description
Verified initiating conversation with or without page context, conversation is retained between browser restarts
Verified page context conversation with follow-up questions work as expected even in full page view
Verified deleting browsing data under basic with page context conversation is retained between browser restart.
Encountered #43398 when only browser data is deleted without restarting browser
Verified selecting Leo-Data under Advanced in clear browsing data, removes all conversation history

Scenario A	Scenario B	Scenario C
42800-A.mp4	42800-B.mp4	42800-C.mp4

Verification passed on

Brave	1.75.162 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
Revision	1c01fd7f190ad7c9c88cb964f55e35400bf399ae
OS	Linux

Verified steps from issue description
Verified initiating conversation with or without page context, conversation is retained between browser restarts
Verified page context conversation with follow-up questions work as expected even in full page view
Verified deleting browsing data under basic with page context conversation is retained between browser restart.
Encountered #43398 when only browser data is deleted without restarting browser
Verified selecting Leo-Data under Advanced in clear browsing data, removes all conversation history

Scenario A	Scenario B	Scenario C
42800-A.mp4	42800-B.mp4	42800-C.mp4

Verification passed on

Brave	1.75.162 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
Revision	1c01fd7f190ad7c9c88cb964f55e35400bf399ae
OS	macOS Version 15.2 (Build 24C101)

Verified steps from issue description
Verified initiating conversation with or without page context, conversation is retained between browser restarts
Verified page context conversation with follow-up questions work as expected even in full page view
Verified deleting browsing data under basic with page context conversation is retained between browser restart.
Encountered #43398 when only browser data is deleted without restarting browser
Verified selecting Leo-Data under Advanced in clear browsing data, removes all conversation history

Scenario A	Scenario B	Scenario C
42800-A.mov	42800-B.mov	42800-C.mov

srirambv · 2025-01-29T12:00:30Z

Verification passed on Google Pixel 8 with Android 15 running 1.75.166 x64 Beta build

Verified steps from issue description
Verified initiating conversation with or without page context, conversation is retained between browser restarts
Verified page context conversation with follow-up questions work as expected even in full page view
Verified deleting browsing data under basic with page context conversation is retained between browser restart.
Encountered #43398 when only browser data is deleted without restarting browser
Verified selecting Leo-Data under Advanced in clear browsing data, removes all conversation history
Encountered #43575

Scenario A	Scenario B	Scenario C
42800-A.mp4	42800-B.mp4	42800-C.mp4

Uni-verse · 2025-02-06T16:36:14Z

Verified on Samsung Galaxy Tab S7 using the following version:

Brave	1.75.175 Chromium: 133.0.6943.54 (Official Build) (64-bit) 
Revision	8e82be95a27b2e442e0099307c0c8ad6d12adcf0
OS	Android 13; Build/TP1A.220624.014; 33; REL

Verified steps from issue description
Verified initiating conversation with or without page context, conversation is retained between browser restarts
Verified page context conversation with follow-up questions work as expected even in full page view
Verified deleting browsing data under basic with page context conversation is retained between browser restart.
Encountered #43398 when only browser data is deleted without restarting browser
Verified selecting Leo-Data under Advanced in clear browsing data, removes all conversation history
Encountered #43575

Step A	Step B	Step C

petemill added this to the 1.74.x - Beta milestone Dec 10, 2024

petemill self-assigned this Dec 10, 2024

petemill modified the milestones: 1.74.x - Beta, 1.75.x - Nightly Dec 10, 2024

petemill mentioned this issue Dec 10, 2024

AIChat conversation data storage brave/brave-core#25876

Merged

5 tasks

petemill closed this as completed Dec 11, 2024

petemill added QA/Yes release-notes/include OS/Desktop OS/Android Fixes related to Android browser functionality labels Dec 11, 2024

petemill mentioned this issue Dec 11, 2024

AI Chat Full Page Storage feature (uplift to 1.74.x) brave/brave-core#26977

Closed

This was referenced Dec 19, 2024

AI Chat history feature should be disabled by default on Android #42928

Closed

Android Settings can delete Leo AI history #42995

Closed

LaurenWags added browser-ai QA/Test-All-Platforms labels Jan 7, 2025

srirambv added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 21, 2025

srirambv added QA Pass-Win64 QA Pass-macOS QA Pass-Linux labels Jan 21, 2025

srirambv removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 21, 2025

srirambv added the QA Pass - Android ARM label Jan 29, 2025

LaurenWags mentioned this issue Feb 5, 2025

Desktop Release Notes for 1.75.x Release #43751

Closed

Uni-verse added the QA Pass - Android Tab label Feb 6, 2025

hffvld mentioned this issue Feb 6, 2025

Android Release Notes for 1.75.x - Release #43799

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AI Chat conversations should persist browser restart #42800

AI Chat conversations should persist browser restart #42800

petemill commented Dec 10, 2024 •

edited

Loading

srirambv commented Jan 21, 2025

srirambv commented Jan 29, 2025

Uni-verse commented Feb 6, 2025

AI Chat conversations should persist browser restart #42800

AI Chat conversations should persist browser restart #42800

Comments

petemill commented Dec 10, 2024 • edited Loading

Test Plan

(A) Conversations and all data persists after browser restart

Conversation without content

Conversation with content

(B) Browsing Data deletion

Regular browsing data

(C) Leo Data deletion

srirambv commented Jan 21, 2025

srirambv commented Jan 29, 2025

Uni-verse commented Feb 6, 2025

petemill commented Dec 10, 2024 •

edited

Loading