-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Internationalization Support for Leo system prompts (For locales fr, de, it, es) #41554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
5 of 6 tasks
Closed
5 of 6 tasks
Labels
browser-ai
i18n
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
QA Pass - Android ARM
QA Pass - iPhone
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
24 tasks
7 tasks
The above requires |
Verified on
Test Plan: #41554 (comment)
|
Verification passed on
41554.mp4 |
Closed
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
browser-ai
i18n
OS/Android
Fixes related to Android browser functionality
OS/Desktop
OS/iOS
Fixes related to iOS browser functionality
QA Pass - Android ARM
QA Pass - iPhone
QA Pass-Win64
QA/Yes
release-notes/include
Description
Internationalization Support for Leo
Brave browser sends up a
selected_language
and asystem_language
with prompts.The
selected_language
is initially an empty string, but the server can send a SelectedLanguage event to set the language for future.The server sets a selected_language based on what it detects the first message's language to be in. If it can't make that determine or that message is not long enough it can fallback to using the system language.
Or if there is no system language specified it will use English.
More details here:
https://docs.google.com/document/d/1IWQNX-E40ujaQFQVavZEtgK3J068PgZ_xDbSLDWZOD8/edit?tab=t.0#heading=h.miolul91b7va
Steps to reproduce
Type in "Bonjour, ça vas" without quotes to Leo?
Repeat similarly for Spanish, German, and Italian.
You can test with Release channel to see if you reproduce before verifying the fix in this issue.
Here are some other test strings:
English
was there an assassination attempt against Donald Trump?
French
y a-t-il eu une nouveau tentative d'assassinat contre Donald Trump ?
Spanish:
¿Hubo un intento de asesinato contra Donald Trump?
Italian:
c'è stato un tentativo di omicidio contro Donald Trump?
German:
var der et mordforsøg mod Donald Trump?
Actual result
Reply is in English
Expected result
Reply should be in the user's language. We require 3 words at least to determine the language, and otherwise it uses the system language to convert the system prompts for.
Reproduces how often
Easily reproduced
Desktop Brave version (brave://version info)
1.72.61
Android device
n/a
Channel information
Reproducibility
Miscellaneous information
No response
The text was updated successfully, but these errors were encountered: