Skip to content

Place Inactive tabs settings in the Appearance section #41482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 6 tasks
rebron opened this issue Oct 8, 2024 · 7 comments · Fixed by brave/brave-core#25907
Closed
3 of 6 tasks

Place Inactive tabs settings in the Appearance section #41482

rebron opened this issue Oct 8, 2024 · 7 comments · Fixed by brave/brave-core#25907
Assignees

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 8, 2024

Description

Currently the Inactive tabs setting can only be found via search. We need to place this setting in the Tabs section of brave://settings/appearance
Image

The label should read "Inactive tabs".
Learn more link should go to https://support.brave.com/hc/en-us/articles/30938249371277

Steps to reproduce

  1. Open brave://settings/appearance
  2. Scroll down to the Tabs section.
  3. Should see the setting above.

Actual result

Image

Expected result

See description.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.70.x and higher

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@rebron rebron added OS/Desktop feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 8, 2024
@rebron
Copy link
Collaborator Author

rebron commented Oct 8, 2024

cc: @Brave-Matt https://support.google.com/chrome/answer/12929150?visit_id=638639901728771855-1809399932&p=performance_personalization&rd=1 article reference from Chrome.

@emerick
Copy link
Contributor

emerick commented Oct 9, 2024

@rebron PR is ready to go, just need the correct learn more URL.

@Brave-Matt
Copy link

@emerick you can use this link for the learn more URL (note that it is currently in draft so will not be visible until article goes live but link will be the same):
https://support.brave.com/hc/en-us/articles/30938249371277

@emerick
Copy link
Contributor

emerick commented Oct 9, 2024

@emerick you can use this link for the learn more URL (note that it is currently in draft so will not be visible until article goes live but link will be the same): https://support.brave.com/hc/en-us/articles/30938249371277

Thank you!

@LaurenWags
Copy link
Member

@brave/qa-team can see notes under brave/brave-core#25907 (comment). Keep in mind:

See https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1728568063554079 for discussion.

@LaurenWags
Copy link
Member

Requires 1.71.113 or higher for verification 👍🏻

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 16, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 16, 2024

Verification PASSED on

Brave | 1.71.113 Chromium: 130.0.6723.58 (Official Build) (64-bit)
-- | --
Revision | 3ee74228044546a84c661332ddb441a7a68108fa
OS | Windows 10 Version 22H2 (Build 19045.5011)

Reproduced the issue on 1.70.126

1.70.126 1.70.126
Image Image

Confirmed using STR from #41482 (comment) that the setting is now in the "Tabs" section of brave://settings/appearance

Support article https://support.brave.com/hc/en-us/articles/30938249371277 is not live yet

1.71.113 1.71.113
Image Image

Confirmed this setting worked as expected:

  1. Installed 1.73.5
  2. Opened a few sites in tabs
  3. Opened brave://discards in a new tab
  4. Chose a site and selected "Proactive Discard" in the "Actions" tab
  5. Confirmed when "Inactive tabs appearance" is enabled, the site's favicon showed a dotted circle around it
  6. Confirmed when "Inactive tabs appearance" is disabled, the site's favicon does not change

Image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 16, 2024
@rebron rebron removed this from Settings Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants