Skip to content

Remember a user's contact information that they provide in a webcompat report and auto-fill it #40021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ShivanKaul opened this issue Jul 25, 2024 · 8 comments · Fixed by brave/brave-core#26286
Closed

Remember a user's contact information that they provide in a webcompat report and auto-fill it #40021

ShivanKaul opened this issue Jul 25, 2024 · 8 comments · Fixed by brave/brave-core#26286
Assignees
@vadimstruts
Labels
feature-request OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPad QA Pass - iPhone QA Pass-Linux QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include webcompat/reporter Bugs/features for Webcompat Reporter
Milestone
1.75.x - Release

Comments

@ShivanKaul
Copy link
Collaborator

ShivanKaul commented Jul 25, 2024 •
edited
Loading

Platforms

all

Description

We optionally ask for users to give us their contact information in webcompat reports so @ryanbr can follow-up with them. If they fill in their contact information for one report, we should remember and store that locally, so we can auto-populate it for future reports.

image

  1. If a user removes the contact information on a subsequent report, then we should not auto-populate it for the next report either. In other words, every N+1th report should auto-populate with the contact information sent in the Nth report.
  2. The data stored here should only be for that specific profile, and should be erased when the user erases data. We should not store contact info if the user is in Private Window or Tor mode.
  3. We'll also add a new toggle in brave://settings/shields (at the end before Content filtering): Store contact information for future broken site reports with default ON.
  4. Lastly, we will add a new line in the Submit report panel above the Submit button, right before the Learn More link: "If you provide contact info it will be stored for future reports."
@ShivanKaul ShivanKaul added priority/P4 Planned work. We expect to get to it "soon". feature-request webcompat/reporter Bugs/features for Webcompat Reporter OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/include labels Jul 25, 2024
@vadimstruts vadimstruts self-assigned this Sep 12, 2024
@vadimstruts vadimstruts linked a pull request Oct 29, 2024 that will close this issue
Remember a user's contact information that they provide in a webcompat report and auto-fill it brave/brave-core#26286
Merged
24 tasks
@vadimstruts vadimstruts mentioned this issue Oct 29, 2024
Merged
24 tasks
vadimstruts added a commit to brave/brave-core that referenced this issue Nov 13, 2024
@vadimstruts
Remember a user's contact information that they provide in a webcompa…
46d0345 
…t report and auto-fill it (#26286)

Remember a user's contact information that they provide in a webcompat report and auto-fill it
(brave/brave-browser#40021)
---------

Signed-off-by: Vadym Struts <[email protected]>
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 13, 2024
@MadhaviSeelam
Copy link

Adding label:QA/Test-All-Platforms label as per the issue description.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 30, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.75.133 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | ce1787778a7a5d92e63a29f8be965494ef49cbbd
OS | Windows 11 Version 24H2 (Build 26100.2605)
Case 1: Normal Window - PASSED
  1. Installed 1.75.133
  2. launched Brave
  3. opened brave://settings/shields in a new tab
  4. verified Store contact information for future broken site reports toggle turned On by default
  5. visited bbc.com in a new tab
  6. clicked Shields icon in the URL bar
  7. turned Off the toggle to Shields Down
  8. clicked "Report broken site" in the Shields panel
  9. entered additional details and contact information in the form
  10. Click "Submit"
  11. confirmed Report a broken site dialog dismissed and Thank you!! message is shown
  12. clicked Shields icon -->Report broken site again
  13. closed Brave and restarted Brave
  14. clicked Shields icon -->Report broken site again
  15. verified contact info is still populated in the form

Confirmed contact information that was entered previously is shown in the dialog

step 4 step 7 step 9 step 11 step 12 step 15
Image Image Image Image Image Image
Case 2: Private Window - PASSED
  1. Continue from Case 1
    • Shields is down for bbc.com
  2. opened Private window via hamburger menu
  3. visited bbc.com
  4. verified Shields is DOWN
  5. clicked Shields icon --> Report site

Confirmed the dialog is blank, i.e. previously entered contact info in the Normal window does not appear in the Private window.

step 1 step 4 step 5
Image Image Image
Case 3: Normal window with webcompat reports to OFF - PASSED
  1. Return to Normal window
  2. toggle Off for Store contact information for future broken site reports in brave://settings/shields
  3. opened nytimes.com in a new tab
  4. clicked Shields icon in the URL bar
  5. turned Off the toggle to Shields Down
  6. clicked "Report broken site" in the Shields panel
  7. entered contact information
  8. Click "Submit"
  9. confirmed Report a broken site dialog dismissed and Thank you!! message is shown
  10. clicked Shields icon -->Report broken site again

Confirmed previously entered contact info is not preserved in the dialog

step 2 step 5 step 7 step 9 step 10
Image Image Image Image Image

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 7, 2025
@hffvld
Copy link
Contributor

hffvld commented Jan 7, 2025 •
edited
Loading

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7.2
Brave build: 1.75 (151)
BraveCore: 1.75.151 (132.0.6834.57)
Test Case 1: Standard Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Install and launch Brave
  2. Hamburger menu > Settings
  3. Shields & Privacy > Verify that Store contact information for future broken site reports is ON by default
  4. Close the settings and open any website in the new tab
  5. Tap Brave Shields > Turn it Off
  6. Report a Broken Site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent and the message is dismissed
  8. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is shown
  9. Close and restart Brave
  10. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is shown

ACTUAL RESULTS:

  • Verified that Store contact information for future broken site reports is ON by default.
  • Verified that the report for the broken site could be sent and that the message had been dismissed.
  • Verified that the previously entered Contact info is shown in the text field even after closing and relaunching Brave.
1 2 3
1 2 3
1 2 3
Test Case 2: Private Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Continue from Test Case 1
  2. Open a new Private tab > Go to any website
  3. Tap Brave Shields > Turn it Off if it was On > Verify that the previously entered (in 'Standard tab') Contact info is NOT shown in the text field
  4. Enter Additional details and Contact info
  5. Tap Submit > Verify that the report is sent and the message is dismissed
  6. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is NOT shown

ACTUAL RESULTS:

  • Verified that the previously entered (in the Standard or Private tab) Contact info is NOT shown in the text field.
  • Verified that the report for the broken site could be sent and that the message had been dismissed.
1 2 3
1 2 3
1 2 3
Test Case 3: Standard Tab and "Store contact information for future broken site reports" is OFF

STEPS:

  1. Continue from Test Case 1 or 2
  2. Hamburger menu > Settings
  3. Shields & Privacy > Turn Off Store contact information for future broken site reports
  4. Close the settings and open any website in the Standard tab
  5. Tap Brave Shields > Turn it Off
  6. Report a Broken Site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent and the message is dismissed
  8. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is NOT shown

RESULTS:**

  • Verified that Store contact information for future broken site reports can be disabled.
  • Verified that the report for the broken site could be sent and that the message had been dismissed.
  • Verified that the previously entered Contact info is NOT shown in the text field.
1 2 3
1 2 3
1 2 3

@MadhaviSeelam MadhaviSeelam mentioned this issue Jan 8, 2025
Closed
@hffvld hffvld mentioned this issue Jan 8, 2025
Closed
5 tasks
@hffvld
Copy link
Contributor

hffvld commented Jan 8, 2025 •
edited
Loading

Verified on iPad Mini (6th gen) using version(s):

Device/OS: iPad Mini (6th gen) / iPadOS 18.2.1
Brave build: 1.75 (154)
BraveCore: 1.75.154 (132.0.6834.57)

Filed follow-up issue #43186

Test Case 1: Standard Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Install and launch Brave
  2. Hamburger menu > Settings
  3. Shields & Privacy > Verify that Store contact information for future broken site reports is ON by default
  4. Close the settings and open any website in the new tab
  5. Tap Brave Shields > Turn it Off
  6. Report a Broken Site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent and the message is dismissed
  8. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is shown
  9. Close and restart Brave
  10. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is shown

ACTUAL RESULTS:

  • Verified that Store contact information for future broken site reports is ON by default.
  • Verified that the report for the broken site could be sent and that the message had been dismissed.
  • Verified that the previously entered Contact info is shown in the text field even after closing and relaunching Brave.
  • Observed that webcompat report/call is not sent - [Follow up to #40021] Webcompat report/call is not sent #43186.
1 2 3
1 2 3
1 2 3
Test Case 2: Private Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Continue from Test Case 1
  2. Open a new Private tab > Go to any website
  3. Tap Brave Shields > Turn it Off if it was On > Verify that the previously entered (in 'Standard tab') Contact info is NOT shown in the text field
  4. Enter Additional details and Contact info
  5. Tap Submit > Verify that the report is sent and the message is dismissed
  6. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is NOT shown

ACTUAL RESULTS:

  • Verified that the previously entered (in the Standard or Private tab) Contact info is NOT shown in the text field.
  • Verified that the report for the broken site could be sent and that the message had been dismissed.
  • Observed that webcompat report/call is not sent - [Follow up to #40021] Webcompat report/call is not sent #43186.
1 2 3
1 2 3
1 2 3
Test Case 3: Standard Tab and "Store contact information for future broken site reports" is OFF

STEPS:

  1. Continue from Test Case 1 or 2
  2. Hamburger menu > Settings
  3. Shields & Privacy > Turn Off Store contact information for future broken site reports
  4. Close the settings and open any website in the Standard tab
  5. Tap Brave Shields > Turn it Off
  6. Report a Broken Site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent and the message is dismissed
  8. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is NOT shown

RESULTS:**

  • Verified that Store contact information for future broken site reports can be disabled.
  • Verified that the report for the broken site could be sent and that the message had been dismissed.
  • Verified that the previously entered Contact info is NOT shown in the text field.
  • Observed that webcompat report/call is not sent - [Follow up to #40021] Webcompat report/call is not sent #43186.
1 2 3
1 2 3
1 2 3

@hffvld hffvld added QA Pass - iPad and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 8, 2025
@hffvld
Copy link
Contributor

hffvld commented Jan 15, 2025 •
edited
Loading

Verified on Galaxy Z Fold 6 using version(s):

Device/OS: Galaxy Z Fold 6 / q6quew-user 14 UP1A.231005.007 release-keys
Brave build: 1.75.159
Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
Test Case 1: Standard Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Install and launch Brave
  2. Hamburger menu > Settings
  3. Shields & Privacy > Verify that Store contact information for future broken site reports is ON by default
  4. Close the settings and open any website in the new tab
  5. Tap Brave Shields > Turn it Off
  6. Report a broken site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent
  8. Open Brave Shields again > Report a broken site > Verify that previously entered Contact info is shown
  9. Close and restart Brave
  10. Open Brave Shields again > Report a broken site > Verify that previously entered Contact info is shown

ACTUAL RESULTS:

  • Verified that Store contact information for future broken site reports is ON by default.
  • Verified that the report for the broken site could be sent successfully.
  • Verified that the previously entered Contact info is shown in the text field even after closing and relaunching Brave.
  • Verified that https://webcompat.brave.com report/call contains Additional details and Contact info.
1 2 3
1 2 3
1 2 3
Test Case 2: Private Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Continue from Test Case 1
  2. Open a new Private tab > Go to any website
  3. Tap Brave Shields > Turn it Off if it was On
  4. Report a broken site > Verify that the previously entered (in 'Standard tab') Contact info is NOT shown in the text field
  5. Enter Additional details and Contact info
  6. Tap Submit > Verify that the report is sent and the message is dismissed
  7. Open Brave Shields again > Report a broken site > Verify that previously entered Contact info is NOT shown

ACTUAL RESULTS:

  • Verified that the previously entered (in the Standard or Private tab) Contact info is NOT shown in the text field.
  • Verified that the report for the broken site could be sent successfully.
  • Verified that https://webcompat.brave.com report/call contains Additional details and Contact info.
1 2 3
1 2 3
1 2 3
Test Case 3: Standard Tab and "Store contact information for future broken site reports" is OFF

STEPS:

  1. Continue from Test Case 1 or 2
  2. Hamburger menu > Settings
  3. Shields & Privacy > Turn Off Store contact information for future broken site reports
  4. Close the settings and open any website in the Standard tab
  5. Tap Brave Shields > Turn it Off
  6. Report a broken site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent
  8. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is NOT shown

RESULTS:**

  • Verified that Store contact information for future broken site reports can be disabled.
  • Verified that the report for the broken site could be sent successfully.
  • Verified that the previously entered Contact info is NOT shown in the text field.
  • Verified that https://webcompat.brave.com report/call contains Additional details and Contact info.
1 2 3
1 2 3
1 2 3

@hffvld
Copy link
Contributor

hffvld commented Jan 16, 2025

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
Brave build: 1.75.159
Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
Test Case 1: Standard Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Install and launch Brave
  2. Hamburger menu > Settings
  3. Shields & Privacy > Verify that Store contact information for future broken site reports is ON by default
  4. Close the settings and open any website in the new tab
  5. Tap Brave Shields > Turn it Off
  6. Report a broken site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent
  8. Open Brave Shields again > Report a broken site > Verify that previously entered Contact info is shown
  9. Close and restart Brave
  10. Open Brave Shields again > Report a broken site > Verify that previously entered Contact info is shown

ACTUAL RESULTS:

  • Verified that Store contact information for future broken site reports is ON by default.
  • Verified that the report for the broken site could be sent successfully.
  • Verified that the previously entered Contact info is shown in the text field even after closing and relaunching Brave.
  • Verified that https://webcompat.brave.com report/call contains Additional details and Contact info.
1 2 3
1 2 3
1 2 3
Test Case 2: Private Tab and "Store contact information for future broken site reports" is ON

STEPS:

  1. Continue from Test Case 1
  2. Open a new Private tab > Go to any website
  3. Tap Brave Shields > Turn it Off if it was On
  4. Report a broken site > Verify that the previously entered (in 'Standard tab') Contact info is NOT shown in the text field
  5. Enter Additional details and Contact info
  6. Tap Submit > Verify that the report is sent and the message is dismissed
  7. Open Brave Shields again > Report a broken site > Verify that previously entered Contact info is NOT shown

ACTUAL RESULTS:

  • Verified that the previously entered (in the Standard or Private tab) Contact info is NOT shown in the text field.
  • Verified that the report for the broken site could be sent successfully.
  • Verified that https://webcompat.brave.com report/call contains Additional details and Contact info.
1 2 3
1 2 3
1 2 3
Test Case 3: Standard Tab and "Store contact information for future broken site reports" is OFF

STEPS:

  1. Continue from Test Case 1 or 2
  2. Hamburger menu > Settings
  3. Shields & Privacy > Turn Off Store contact information for future broken site reports
  4. Close the settings and open any website in the Standard tab
  5. Tap Brave Shields > Turn it Off
  6. Report a broken site > Enter Additional details and Contact info
  7. Tap Submit > Verify that the report is sent
  8. Open Brave Shields again > Report a Broken Site > Verify that previously entered Contact info is NOT shown

RESULTS:**

  • Verified that Store contact information for future broken site reports can be disabled.
  • Verified that the report for the broken site could be sent successfully.
  • Verified that the previously entered Contact info is NOT shown in the text field.
  • Verified that https://webcompat.brave.com report/call contains Additional details and Contact info.
1 2 3
1 2 3
1 2 3

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 27, 2025 •
edited
Loading

Verification PASSED using

Brave | 1.75.168 Chromium: 132.0.6834.111 (Official Build) beta (arm64)
-- | --
Revision | 2b79fecfaacadde603f71291b8292c11ba0d22ac
OS | macOS Version 15.2 (Build 24C101)
Case 1: Normal Window - PASSED
  1. Installed 1.75.168
  2. launched Brave
  3. opened brave://settings/shields in a new tab
  4. verified Store contact information for future broken site reports toggle turned On by default
  5. visited abcnews.com in a new tab
  6. clicked Shields icon in the URL bar
  7. turned Off the toggle to Shields Down
  8. clicked "Report site" in the Shields panel
  9. entered additional details and contact information in the Report a broken site form
  10. Click "Submit"
  11. confirmed Report a broken site dialog dismissed and Thank you!! message is shown
  12. clicked Shields icon -->Report site again
  13. confirmed contact info is still populated in the Report a broken siteform
  14. closed Brave and restarted Brave
  15. clicked Shields icon -->Report site again
  16. verified contact info is still populated in the Report a broken site form

Confirmed contact information that was entered previously is shown in the dialog

step 4 step 7-8 step 9 step 11 step 12 step 15
Image Image Image Image Image Image
Case 2: Private Window - PASSED
  1. Continue from Case 1
    • Shields is down for abcnews.com
    • contact details are populated
  2. opened Private window via hamburger menu
  3. visited abcnews.com
  4. verified Shields is DOWN
  5. clicked Shields icon --> Report site

Confirmed the dialog is blank, i.e. previously entered contact info in the Normal window does not appear in the Private window.

step 1a step1 b step 4 Normal window Private window
Image Image Image Image Image
Case 3: Normal window with webcompat reports to OFF - PASSED
  1. Return to Normal window
  2. toggle Off for Store contact information for future broken site reports in brave://settings/shields
  3. opened nytimes.com in a new tab
  4. clicked Shields icon in the URL bar
  5. turned Off the toggle to Shields Down
  6. clicked "Report broken site" in the Shields panel
  7. entered contact information
  8. Click "Submit"
  9. confirmed Report a broken site dialog dismissed and Thank you!! message is shown
  10. clicked Shields icon -->Report broken site again

Confirmed previously entered contact info is no longer preserved in the dialog

step 2 step 5 step 7 step 9 step 10
Image Image Image Image Image

@btlechowski
Copy link

btlechowski commented Feb 4, 2025 •
edited
Loading

Verified with

Brave 1.75.170 Chromium: 132.0.6834.111 (Official Build) beta (64-bit)
Revision ea6b6fa547193f9769ffb0068880a4f41e364864
OS Linux
Case 1: Normal Window - PASSED
  1. Installed 1.75.x
  2. launched Brave
  3. opened brave://settings/shields in a new tab
  4. verified Store contact information for future broken site reports toggle turned On by default
  5. visited abcnews.com in a new tab
  6. clicked Shields icon in the URL bar
  7. turned Off the toggle to Shields Down
  8. clicked "Report site" in the Shields panel
  9. entered additional details and contact information in the Report a broken site form
  10. Click "Submit"
  11. confirmed Report a broken site dialog dismissed and Thank you!! message is shown
  12. clicked Shields icon -->Report site again
  13. confirmed contact info is still populated in the Report a broken siteform
  14. closed Brave and restarted Brave
  15. clicked Shields icon -->Report site again
  16. verified contact info is still populated in the Report a broken site form

Confirmed contact information that was entered previously is shown in the dialog

Image Image Image Image Image
Case 2: Private Window - PASSED
  1. Continue from Case 1
    • Shields is down for abcnews.com
    • contact details are populated
  2. opened Private window via hamburger menu
  3. visited abcnews.com
  4. verified Shields is DOWN
  5. clicked Shields icon --> Report site

Confirmed the dialog is blank, i.e. previously entered contact info in the Normal window does not appear in the Private window.

Image

Case 3: Normal window with webcompat reports to OFF - PASSED
  1. Return to Normal window
  2. toggle Off for Store contact information for future broken site reports in brave://settings/shields
  3. opened nytimes.com in a new tab
  4. clicked Shields icon in the URL bar
  5. turned Off the toggle to Shields Down
  6. clicked "Report broken site" in the Shields panel
  7. entered contact information
  8. Click "Submit"
  9. confirmed Report a broken site dialog dismissed and Thank you!! message is shown
  10. clicked Shields icon -->Report broken site again

Confirmed previously entered contact info is no longer preserved in the dialog

Image Image Image Image

@LaurenWags LaurenWags mentioned this issue Feb 5, 2025
Closed
@hffvld hffvld mentioned this issue Feb 6, 2025
Closed
@kjozwiak kjozwiak mentioned this issue Feb 11, 2025
Closed
7 tasks
@Uni-verse Uni-verse mentioned this issue Feb 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vadimstruts vadimstruts

Labels
feature-request OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPad QA Pass - iPhone QA Pass-Linux QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include webcompat/reporter Bugs/features for Webcompat Reporter
Projects
None yet
Milestone
1.75.x - Release
7 participants
@cuba @ShivanKaul @btlechowski @brave-builds @MadhaviSeelam @vadimstruts @hffvld