Skip to content

[Wallet] Edit NFT form adds a new token instead of updating the existing token #39921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 6 tasks
josheleonard opened this issue Jul 22, 2024 · 2 comments · Fixed by brave/brave-core#24780
Closed
2 of 6 tasks

Comments

@josheleonard
Copy link

josheleonard commented Jul 22, 2024

Description

Currently, when editing an NFT a new NFT is added and the existing one is still visible.

Steps to reproduce

  1. Load a wallet the owns an ERC721 NFT
  2. edit the NFT via the Edit NFT form

Actual result

The edited NFT is not removed and a new NFT with the edits is added.

brave_YqSx2SxTE9.mp4

Expected result

The edited NFT is removed and a new NFT with the edits is added.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.70.3 Chromium: 127.0.6533.57 (Official Build) nightly (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@kjozwiak
Copy link
Member

The above requires 1.69.123 or higher for 1.69.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.69.124 Chromium: 127.0.6533.73 (Official Build) beta (64-bit)
Revision dbc9035349f74e493f3293d93f4cbf35c597dfec
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from issue description
  • Verified editing an NFT updates the NFT to new value
  • Verified editing an NFT to a different contract address updates the NFT to new value
39921.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants