Skip to content

Edit NFT doesn't update the NFT #33306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Sep 28, 2023 · 2 comments · Fixed by brave/brave-core#24780
Closed

Edit NFT doesn't update the NFT #33306

srirambv opened this issue Sep 28, 2023 · 2 comments · Fixed by brave/brave-core#24780
Assignees
@josheleonard
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.69.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Edit NFT doesn't update the NFT

Steps to Reproduce

  1. Restore wallet with NFT
  2. Edit NFT value (token ID)
  3. Save changes
  4. Doesn't update the NFT to new value

Actual result:

Edit NFT doesn't update the NFT

Expected result:

Edit NFT should update the NFT

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.60.63 Chromium: 118.0.5993.21 (Official Build) nightly (64-bit)
Revision 3c2401f
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam @HEagle18
@srirambv srirambv added this to Web3 Sep 28, 2023
@srirambv srirambv mentioned this issue Sep 28, 2023
Merged
25 tasks
@muliswilliam muliswilliam moved this to Backlog in Web3 Sep 29, 2023
@muliswilliam muliswilliam self-assigned this Sep 29, 2023
@srirambv srirambv mentioned this issue Oct 6, 2023
Closed
@josheleonard josheleonard moved this from Backlog to In Review in Web3 Jul 22, 2024
@josheleonard josheleonard mentioned this issue Jul 22, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 22, 2024
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 22, 2024
@brave-builds brave-builds mentioned this issue Jul 22, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.69.123 or higher for 1.69.x verification 👍

@srirambv
Copy link
Contributor Author

Verified as part of #39921 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): replace NFT with edited token when editing brave/brave-core
5 participants
@kjozwiak @srirambv @josheleonard @brave-builds @muliswilliam