Skip to content

Share/Copy/Edit tools not shown in url bar for sites loaded by only typing eTLD #38563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5 of 6 tasks
Uni-verse opened this issue May 24, 2024 · 4 comments · Fixed by brave/brave-core#23844
Closed
5 of 6 tasks

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented May 24, 2024

Description

Share/Copy/Edit tools are not shown on webpages when focusing on url bar that are loaded by using eTLD+1. For example if you type brave.com without including https://www. this will be the case.

Related to #38507

Steps to reproduce

  1. New install
  2. Open new tab, type in brave.com or https://yahoo.com
  3. Once the page loads, tap on the URL bar

Actual result

Example Example
Screenshot 2024-05-24 at 12 00 53 PM Screenshot 2024-05-24 at 12 01 25 PM

Expected result

Screenshot 2024-05-24 at 10 58 55 AM

Reproduces how often

Easily reproduced

Brave version

1.66.x - reproducible

Device

  • Brand/model: Samsung Galaxy devices
  • Android version: 13

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Chrome behavior when focusing on URL bar clears field and displays the share/copy/edit tools
Brave pre C125 show the tools when focusing on URL bar.

@Uni-verse Uni-verse added feature/url-bar QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels May 24, 2024
@samartnik samartnik self-assigned this May 24, 2024
@Uni-verse Uni-verse changed the title Share/Copy/Edit tools not shown when focusing on url bar for some webpages. Share/Copy/Edit tools not shown in url bar for sites loaded by only typing eTLD May 24, 2024
@hffvld
Copy link
Contributor

hffvld commented May 24, 2024

Brave and Chrome have different behavior:

  • In Brave when you tap on a web address, the address is shown and selected automatically.
  • In Chrome when you tap on a web address, the address is not shown and the Share, Copy, & Edit buttons are shown.

So, in Brave if you type the address without https://www. Share, Copy & Edit are not shown, but if you tap x to remove the address, these buttons appear similar to what Chrome has.

Brave

timestamp_13-39-44_13-40-10.mp4

Chrome

timestamp_13-40-21_13-40-41.mp4

@kjozwiak
Copy link
Member

The above requires 1.66.117 or higher for 1.66.x verification 👍 Added QA/Test-All-Platforms so we're not sure the above is working on Mobile & Tablet.

@Uni-verse
Copy link
Contributor Author

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using version

Brave	1.66.118 Chromium: 125.0.6422.147 (Official Build) (64-bit) 
Revision	07af53490e0a52336cfb99a376f87671be258049
OS	Android 13; Build/TP1A.220624.014; 33; REL
Using link Typing eTLD Clearing url bar
Screenshot 2024-05-31 at 11 59 41 AM Screenshot 2024-05-31 at 12 00 26 PM Screenshot 2024-05-31 at 12 00 31 PM
Screenshot 2024-05-31 at 12 06 38 PM Screenshot 2024-05-31 at 12 07 04 PM Screenshot 2024-05-31 at 12 07 32 PM

@hairycactus
Copy link

@kjozwiak: The above requires 1.66.117 or higher for 1.66.x verification 👍 Added QA/Test-All-Platforms so we're not sure the above is working on Mobile & Tablet.

The Share | Copy | Edit icons are still missing when the URL bar is tapped -- as observed in my:

  • Brave Android v1.66.118 x64 (released: 31 May 2024)
  • OS: Android v12 x64

The only workarounds for copying/ pasting text from/ into the URL bar are either via long-pressing the URL bar, or by using Gboard keypad's text-select tool menu.

Screenshots:

BraveAndroid1.66.118(31May24)-MissingCopyEditPasteOptions-URLBar2

BraveAndroid1.66.118(31May24)-MissingCopyEditPasteOptions-URLBar3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants