Import bookmark link text in the infobar is difficult to read with the new theme colors & updated nala colors

[MadhaviSeelam]

Description

Found while testing #38087. For some of the profile themes with Dark background, particularly import bookmarks now... link is difficult to read

Steps to Reproduce

1. Install 1.66.107
2. launch Brave
3. opened brave://settings/manageProfile
4. select Dark blue, Midnight blue or custom blue

Actual result:

example	example

Expected result:

Need contrasting colors?

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? N/A
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @aguscruiz

[aguscruiz]

Yes, should use the dark mode version of that color. Seems to be using light mode

[simonhong]

Yes, should use the dark mode version of that color. Seems to be using light mode

Correct. we should consider bg color also in this case.

[frypf]

This lack of legibility doesn't just seem isolated to the specific example mention by OP - I'm using the default theme, and having just now upgraded to 1.66.110 I instantly noticed similar difficulties reading items on "brave://discards":

The same is true of other builtin pages, eg. settings etc. Prior to upgrading, all the dark blue clickable items were a nice legible & contrasting shade of orange IIRC.
Changing brave themes doesn't affect anything on these pages - only switching my whole system to light mode makes them readable again.

[frypf]

Ok I see now it's apparently known as the accent colour - forgive my UI ignorance. Was this supposed to have changed from the previous orange with the latest update?

[Rikk]

This issue with color was fixed in 1.65/1.66/1.67 at some time:
#37515 ➔ brave/brave-core#23048 / brave/brave-core#23054 / brave/brave-core#23055
But in 1.66 release (v1.66.110) it is happening again as described here.

[bsclifton]

@frypf yes - the accent color was changed. From the orange to the "blurple" (blue/purple). Thanks for flagging 😄

@Rikk thanks for the additional info! Something may have regressed with the recent Chromium 125 upgrade

[simonhong]

I'll fix this after cr126 is merged into master to avoid conflict with it as cr126 has some related color value changes.

[Rikk]

I'll fix this after cr126 is merged into master to avoid conflict with it as cr126 has some related color value changes.

So, does this mean Brave main color will be "Hard on the Eyes Burple" for the next 3 weeks?

cc @bsclifton

[bsclifton]

@Rikk no - we'll get something earlier 😄 We're just going to fix it in the Chromium 126 code branch first - then we can backport a fix to the Chromium 125 branches (Beta / Release). Thanks for your patience!

[stephendonner]

Verification PASSED using

Brave | 1.68.85 Chromium: 126.0.6478.40 (Official Build) beta (64-bit)
-- | --
Revision | 8e76a669cf78bdfa933c8d569460092a01166588
OS | Windows 10 Version 22H2 (Build 19045.4474)

Followed the steps to reproduce from #38354 (comment)

Confirmed Import bookmarks.... text was readable/higher contrast, compared with previous builds

Blue	Slate Gray	Purple

Also confirmed brave://discards looks good