Add bookmarks button shows wrong count when landing pages are open

[cuba]

Description:

When long pressing the tabs button when on a landing page, add bookmark is not there because i'm on the landing page. But then it shows "add bookmarks for 3 tabs" where one of the tabs is the landing page and so it will add 2 bookmarks instead of 3. So it should say "add bookmarks for 2 tabs" or maybe not show anything at all.

Steps to Reproduce

1. Open a tab and go to any website
2. Open a new tab and stay on the landing page
3. Long press the tabs button ("[1]") in the navigation bar

Actual result:

Shows "Add bookmarks for 2 tabs"

Expected result:

Should either show nothing or ignore landing pages and say "Add bookmarks for 1 tab"

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily

Brave Version:

1.66

• Can you reproduce this issue with the most recent build from TestFlight?
• Can you reproduce this issue with the previous version of the current build from TestFlight?
• Can you reproduce this issue with the current build from AppStore?

Device details:

Any

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Mobile Safari?

Additional Information

[hffvld]

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.6
Brave build: 1.68 (110)
BraveCore: 1.68.110 (127.0.6533.26)

Filed follow-up issue #39590

STEPS:

1. Follow the STR/TP from Add bookmarks button shows wrong count when landing pages are open #38340 (comment) and [iOS] Tab Tray Icon Long Press Enhancements brave-core#23707 (comment)
2. Verify

ACTUAL RESULTS:

• Verified that Add Bookmark for %lld Tabs is not shown when staying on NTP
• Verified that Add Bookmark for %lld Tabs shows the correct number of tabs that must be saved when staying on a tab with any website

---

1	2	3	4