Skip to content

[iOS/Wallet]: Network Settings inside Wallet settings to hide/unhide networks #37741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nuo-xu opened this issue Apr 19, 2024 · 1 comment · Fixed by brave/brave-core#23437
Closed

[iOS/Wallet]: Network Settings inside Wallet settings to hide/unhide networks #37741

nuo-xu opened this issue Apr 19, 2024 · 1 comment · Fixed by brave/brave-core#23437
Assignees
@nuo-xu
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@nuo-xu
Copy link

nuo-xu commented Apr 19, 2024

an iOS version #37397
this needs to be done before #37740
@nuo-xu nuo-xu added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Apr 19, 2024
@nuo-xu nuo-xu self-assigned this Apr 19, 2024
@nuo-xu nuo-xu added this to Web3 Apr 19, 2024
@nuo-xu nuo-xu moved this to In Progress in Web3 Apr 19, 2024
@StephenHeaps StephenHeaps mentioned this issue Apr 30, 2024
Open
@nuo-xu nuo-xu mentioned this issue May 6, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 May 9, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 9, 2024
@srirambv
Copy link
Contributor

srirambv commented Jul 9, 2024

Verification passed on iPhone 13 with iOS 18.0 Beta running 1.68 (115)

  • Verified steps from brave/brave-core#23437
  • Verified network settings shows list of all networks
  • Verified there is an eye-opened button next to the network indicating its enabled
  • Verified clicking on the eye-opened button changes to eye-closed state
  • Verified when network icon has eye-closed, network is hidden in filters
  • Verified upgrading from older version with Show test network disabled, new version has all test networks disabled
  • Verified upgrading from older version with Show test network enabled, new version has all test networks enabled
  • Verified able to add a custom network
  • Verified custom network has Edit, Delete, Set as default buttons in menu
  • Verified every network has Edit and Set as default options
  • Verified editing network works as expected
  • Verified when a network is disabled but then setting Set as default enables the network
37741-1.MP4
37741-2.MP4
37741-3.MP4

@Uni-verse Uni-verse mentioned this issue Sep 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): iOS Wallet Network Settings brave/brave-core
3 participants
@nuo-xu @srirambv @brave-builds