Skip to content

Implement hidden networks in Settings > Brave Wallet > Networks #37397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
simoarpe opened this issue Apr 8, 2024 · 1 comment · Fixed by brave/brave-core#23937
Closed

Implement hidden networks in Settings > Brave Wallet > Networks #37397

simoarpe opened this issue Apr 8, 2024 · 1 comment · Fixed by brave/brave-core#23937
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Apr 8, 2024

Description

The Networks section available in Settings > Brave Wallet > Networks should show all the available networks and indicate which ones are currently hidden offering a similar UI as Desktop.

Settings_-_Wallet_Networks
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Apr 8, 2024
@simoarpe simoarpe self-assigned this Apr 8, 2024
@simoarpe simoarpe added this to Web3 Apr 8, 2024
@simoarpe simoarpe mentioned this issue Apr 8, 2024
Merged
24 tasks
@simoarpe simoarpe moved this to In Progress in Web3 Apr 9, 2024
@nuo-xu nuo-xu mentioned this issue Apr 19, 2024
Closed
@simoarpe simoarpe mentioned this issue May 31, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jun 3, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone Jun 3, 2024
@srirambv
Copy link
Contributor

srirambv commented Jul 1, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.68.99

  • Verified steps from brave/brave-core#23937
  • Verified network settings is shown similar to Desktop
  • Verified selected network is shown in bold
  • Verified able to hide network by tapping on the view button
  • Verified hidden network is not shown in Portfolio settings
  • Verified able to add new network
  • Encountered #39417
37397.mp4

@hffvld hffvld mentioned this issue Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Implement network configuration settings brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds