Skip to content

Unable to sync passwords #36190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
francoism90 opened this issue Feb 18, 2024 · 99 comments · Fixed by brave/brave-core#26876
Closed

Unable to sync passwords #36190

francoism90 opened this issue Feb 18, 2024 · 99 comments · Fixed by brave/brave-core#26876
Assignees
@AlexeyBarabash
Labels
feature/password-manager feature/sync OS/Android Fixes related to Android browser functionality OS/ChromeOS QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.73.x - Release #5

Comments

@francoism90
Copy link

francoism90 commented Feb 18, 2024 •
edited
Loading

Description

It states I need to enable biometrics features/PIN first. The device doesn't have any biometrics features, however it does use encryption and I'm already using a PIN to unlock the device

Steps to reproduce

  1. Install any Brave version on Chromebook/Android (including Nightly, Beta)
  2. Open Sync Preferences
  3. Try to enable Password sync

Actual result

See error message

Expected result

Just work

Issue reproduces how often

Everytime

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone (Pixel 8 - Android 15), Chromebook Lenovo Duet Tablet
  • Android version: Android 15 (beta), ChromeOS (stable, beta & dev)

Brave version

Stable, Beta & Nightly

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information
@francoism90 francoism90 added the OS/Android Fixes related to Android browser functionality label Feb 18, 2024
@VTArxelus
Copy link

Going to bump this.

ChromeOS v124.0.6367.208; Brave v1.65.133

@blmille1
Copy link

blmille1 commented Jul 25, 2024 •
edited
Loading

I'm also getting this on my Intel core i3 Acer Chromebook.
This is literally the first thing I tried to set up. I don't want to switch back to Google Chrome, but this may be the clincher.
I have a PIN, local password (instead of logging in via my Google account) set up on the Chromebook.
I have it set up to lock the screen on sleep/shutting the lid.
What else do I need to do to convince Brave to sync the passwords?

@Jefferderp
Copy link

Identical issue.

Pixel 7, Android 14, GrapheneOS, rooted w/ Magisk, lockscreen PIN enabled. Brave has been installed for 1-2 years.

@mguerrilla
Copy link

Same problem Samsung Galaxy s20fe

@FurloSK
Copy link

FurloSK commented Aug 8, 2024

Same problem with Huawei P20 :-/

@francoism90
Copy link
Author

This is actually a life safer, I moved to Proton Pass. :)

@OFiberPH
Copy link

Same here, unable to turn on password sync even after authenticating via fingerprint.

Tasted on the ff units using the Play store version:
Samsung Galaxy Tab S9 Ultra Android 14
Samsung Galaxy S23 Ultra Android 14
Samsung Galaxy A55 5G Android 14

@VTArxelus
Copy link

VTArxelus commented Aug 10, 2024 •
edited
Loading

Identical issue.

Pixel 7, Android 14, GrapheneOS, rooted w/ Magisk, lockscreen PIN enabled. Brave has been installed for 1-2 years.

This ticket is for ChromeOS, not Android.

@VTArxelus
Copy link

VTArxelus commented Aug 10, 2024 •
edited
Loading

Same problem Samsung Galaxy s20fe

This ticket is for ChromeOS, not Android.

@VTArxelus
Copy link

Same problem with Huawei P20 :-/

This ticket is for ChromeOS, not Android.

@VTArxelus
Copy link

Same here, unable to turn on password sync even after authenticating via fingerprint.

Tasted on the ff units using the Play store version:
Samsung Galaxy Tab S9 Ultra Android 14
Samsung Galaxy S23 Ultra Android 14
Samsung Galaxy A55 5G Android 14

This ticket is for ChromeOS, not Android.

@francoism90 francoism90 changed the title [ChromeOS/Chromebook] Unable to sync passwords Unable to sync passwords Aug 10, 2024
@francoism90
Copy link
Author

@VTArxelus I have updated the issue, as the same happens on Android devices now.

@joewood9364
Copy link

This is actually a life safer, I moved to Proton Pass. :)

Yeah all these guys do is reskin chrome and they still have bugs open for months with no fix.

@mojhale
Copy link

mojhale commented Aug 17, 2024

Soooo, should I change password managers or change browsers? There are plenty of options out there, and some of them probably work. I kind of need passwords when I'm not at my computer.

@Arora-Sir
Copy link

@mojhale commented on Aug 17, 2024, 6:04 AM GMT+5:30:

Soooo, should I change password managers or change browsers? There are plenty of options out there, and some of them probably work. I kind of need passwords when I'm not at my computer.

Please let me know if you've found some workout instead of resetting the brave from phone (this solved it for a while), but again after few days brave have this same issue!

@VTArxelus
Copy link

I have a few ideas...

  1. This bug report should be for ChromeOS as it was originally intended, not including Android. ChromeOS is a different base from Android. And while, yes, modern ChromeOS is capable of using the play store, the distinction is the store converts packages for install using a method that makes it quite seamless. We there is something with Brave that is getting broken, and it should be fixed rather being pushed to the back burner while we are forced to

  2. Use external password managers. This should not be a resort, because no password manager has seamless integration in Android or ChromeOS, but where necessary we can keep passwords updated on both sides quite easily with a transferable file. Extra hoops than this should not be required.

@mojhale
Copy link

mojhale commented Aug 20, 2024

@VTArxelus

  1. Shall I create another post with the same manifest problems but tag it for Android? I don't use ChromeOS and am experiencing this issue.
  2. I'm not sure I'm following. Are you suggesting exporting my passwords from my laptop, transferring the file, then finding the way to import them (as the setting for importing passwords from a file isn't evident)? I really try to avoid transferring files in plaintext between devices. I do have another browser that I used to use that has password management that works seamlessly...

@francoism90
Copy link
Author

It's already tagged for both, and also assigned.

@joewood9364
Copy link

I don't get why this is not prioritised higher. Password sync is core functionality of Brave and can lead to people getting locked out of accounts.

@mojhale
Copy link

mojhale commented Aug 28, 2024

Also, I just learned that there's not actually a way to import passwords into the Android app: https://community.brave.com/t/password-import-on-ipad-and-android/527932/5
I really wish I could continue using Brave, but it isn't working for me to not be able to sign in to accounts when I'm not at home.

@NicholasFlamy
Copy link

NicholasFlamy commented Aug 28, 2024 •
edited
Loading

This is really really bad.
Brave 1.69.153
Android 14 OneUI 6.1 Samsung S22

@NicholasFlamy
Copy link

NicholasFlamy commented Aug 28, 2024 •
edited
Loading

Same here, unable to turn on password sync even after authenticating via fingerprint.
Tasted on the ff units using the Play store version:
Samsung Galaxy Tab S9 Ultra Android 14
Samsung Galaxy S23 Ultra Android 14
Samsung Galaxy A55 5G Android 14

This ticket is for ChromeOS, not Android.

Is there an open Android ticket?

@francoism90 francoism90 mentioned this issue Aug 30, 2024
Closed
6 tasks
@Saoiray
Copy link

Saoiray commented Aug 31, 2024

@NicholasFlamy and @francoism90 I've been hearing mixed reviews from people. Have you recently tested Beta and/or Nightly? If so, I'd be curious to see if it works for you there. So far I'm seeing people with Android saying it works, but not necessarily people on ChromeOS.

@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 6, 2024
This was referenced Dec 6, 2024
Merged
Merged
@AlexeyBarabash
Copy link
Contributor

Fix is merged to Nightly, must be at the next Nightly build.

Uplifts to Beta and Release are created: link

@Tbrot79
Copy link

Tbrot79 commented Dec 7, 2024

Updated brave on all devices and still does not sync passwords!

Same as before asks for password/biometrics and then does not allow you to toggle the password sync button to the on position.

anyone else?

@Saoiray
Copy link

Saoiray commented Dec 7, 2024

Updated brave on all devices and still does not sync passwords!

Same as before asks for password/biometrics and then does not allow you to toggle the password sync button to the on position.

anyone else?

Umm, @Tbrot79 it's generally helpful if you can try to be more clear on things. If you look at what has been said, the fix was arriving on Nightly. Then it will be getting uplifted to others. You come and speak about updating on all devices, but you fail to mention if it's on Nightly, Beta, or Release. Nor do you even say which specific version.

Safe to assume you're just not paying attention and are rushing things? I mean, not even sure the fix hit Nightly yet. And if you look at brave/brave-core#26919 you'd see that the merging to 1.73.x is blocked and hasn't happened yet. Same for brave/brave-core#26918 which is 1.74.x

And I'm now seeing your comment at brave/brave-core#26876 (comment) where you shared you're on 1.73.x. So yeah, you're just rushing and not paying attention. Patience....it's coming.

@HunterMeyer
Copy link

@AlexeyBarabash thank you for updating us and fixing this issue (🤞). Do you have a Buy me a Coffee? Would love to reward your efforts.

@u2rcrazybaby
Copy link

u2rcrazybaby commented Dec 8, 2024 via email

@VTArxelus
Copy link

I've restarted, and updated Brave. The problem is still occurring.

On Sat, Dec 7, 2024, 5:00 PM Hunter @.***> wrote:

@AlexeyBarabash https://github.com/AlexeyBarabash thank you for
updating us and fixing this issue (🤞). Do you have a Buy me a Coffee?
Would love to reward your efforts.

—
Reply to this email directly, view it on GitHub
#36190 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BM4D3COEK4UN3RZVIYHXNQT2EOK3JAVCNFSM6AAAAABDOF5B2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRVGM3DIOBUGA
.
You are receiving this because you commented.Message ID:
@.***>

You must be running the Nightly build of Brave as it has not gone to Beta or Stable yet.

@bsclifton
Copy link
Member

Hi folks - thanks for the comments. This fix is not released yet. Please stay tuned- we should have a 1.73.x release with this fix in the next week or so. You can watch brave/brave-core#26919 and when that code gets merged you'll know we're close to a release. Thanks!

@kjozwiak
Copy link
Member

The above requires 1.73.100 or higher for 1.73.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 10, 2024
@hffvld
Copy link
Contributor

hffvld commented Dec 10, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 15 BP11.241025.006 release-keys
Brave build: 1.73.100
Chromium: 131.0.6778.108 (Official Build) (64-bit)

STEPS:

  1. Follow the STR/TP from Fixed issue of unable to switch on the passwords sync on Android brave-core#26876 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that Passwords can be synced successfully for the new and upgraded account.

Galaxy Tab S8

2024-12-10_15-26-38.mp4

Pixel 7

2024-12-10_14-57-05.mp4

@u2rcrazybaby
Copy link

u2rcrazybaby commented Dec 11, 2024 via email

@hffvld hffvld mentioned this issue Dec 11, 2024
Closed
6 tasks
@hffvld
Copy link
Contributor

hffvld commented Dec 11, 2024

Verified on Acer CX5400 using version(s):

Device/OS: Acer CX5400 / ChromeOS 130.0.6723.126 (Official Build) (64-bit) 
Brave build: 1.73.100
Chromium: 131.0.6778.108 (Official Build) (64-bit)

Filed follow-up issue #42816

STEPS:

  1. Follow the STR/TP from Fixed issue of unable to switch on the passwords sync on Android brave-core#26876 (comment)
  2. Verify

ACTUAL RESULTS:

  • Observed that Passwords can NOT be synced successfully for the new and upgraded account.
2.mov

@hffvld hffvld removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 11, 2024
@smemsh
Copy link

smemsh commented Dec 11, 2024

I have restarted my phone and check for an update, but there is no update available . Brave browser is still not syncing passwords. ... [I have version] 1.73.97

the fix is not present until stable >= 1.73.100 or beta >= 1.74.25

@hffvld hffvld mentioned this issue Dec 11, 2024
Closed
@smemsh
Copy link

smemsh commented Dec 13, 2024

Confirmed, it's now fixed for me on Pixel 6 Pro in beta 1.74.26, woohoo! Did not have to do anything to make it work, it synced immediately after upgrade, and now all sync sliders are enabled, no red

Thanks for your persistence implementing the right fix @AlexeyBarabash, and thank you @bsclifton for ensuring that this got scheduled!

@NjordCZ
Copy link

NjordCZ commented Feb 26, 2025

Same problem on SailfishOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
feature/password-manager feature/sync OS/Android Fixes related to Android browser functionality OS/ChromeOS QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.73.x - Release #5
Development

Successfully merging a pull request may close this issue.

Fixed issue of unable to switch on the passwords sync on Android brave/brave-core