Skip to content

[Leo] - Update to individual chat design #35177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
aguscruiz opened this issue Jan 8, 2024 · 4 comments · Fixed by brave/brave-core#21808
Closed
3 tasks done

[Leo] - Update to individual chat design #35177

aguscruiz opened this issue Jan 8, 2024 · 4 comments · Fixed by brave/brave-core#21808

Comments

@aguscruiz
Copy link

aguscruiz commented Jan 8, 2024

Made an update to each conversation item with the following:

Figma:
https://www.figma.com/file/m0Gdbf0wtqyfEFGm32VLLc/Leo?type=design&node-id=1492%3A64269&mode=design&t=STQ64VGMlUZx8NCH-1

General (both user input and response):

  • Changed vertical padding from 32px to 16px
image

User input

  • Removed the background color for the whole input (instead of gray it's now transparent)
  • The avatar circle is now gray
image
@aguscruiz aguscruiz added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 8, 2024
@nullhook nullhook moved this to Important / Polish in Browser AI Jan 22, 2024
@nullhook nullhook moved this from Important / Polish to In Progress in Browser AI Jan 30, 2024
@nullhook nullhook moved this from In Progress to In Review in Browser AI Jan 30, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Browser AI Feb 1, 2024
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Feb 1, 2024
@stephendonner
Copy link

stephendonner commented Feb 2, 2024

Verification PASSED using

Brave | 1.64.41 Chromium: 121.0.6167.139 (Official Build) nightly (x86_64)
-- | --
Revision | 1c56846eb16cec835298c09cd75ec45fc425507b
OS | macOS Version 14.4 (Build 23E5180j)

Confirmed the following:

  • Vertical padding
  • Background color changed to transparent
  • Avatar circle is now gray
beta (1.63.141) nightly (1.64.41)
Screenshot 2024-02-01 at 11 02 46 PM Screenshot 2024-02-01 at 11 02 59 PM

@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2024

Removing QA Pass the above will need to be re-checked via 1.63.x as we uplifted as per brave/brave-core#21944 (review). Used #35177 (comment) as the needed verification to uplift into 1.63.x.

The above requires 1.63.149 or higher for 1.63.x verification 👍

@MadhaviSeelam
Copy link

Verified PASSED using

Brave | 1.63.149 Chromium: 121.0.6167.164 (Official Build) beta (64-bit)
-- | --
Revision | 16509c04a66afcc00d180c0b62a887b9fc4776a2
OS | Windows 11 Version 23H2 (Build 22631.3085)

Confirmed following as per Figma designs:

  • Vertical padding
  • Background color changed to transparent
  • Avatar circle is now gray
1.62.x 1.63.x
image image

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 14, 2024
@hffvld
Copy link
Contributor

hffvld commented Feb 14, 2024

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
- Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.63.153
Chromium: 121.0.6167.164 (Official Build) beta (64-bit) 

STEPS:

  1. Followed the steps from [Leo] - Update to individual chat design #35177 (comment)

ACTUAL RESULTS:

  • Verified that vertical padding is 16px for both user input and response
  • Verified that the background color for the whole input is now transparent
  • Verified that the avatar circle is now gray

1 2
1 2
1 2
1 2
1 2
1 2

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants