Skip to content

Add brave-core debounce layers for iOS #33275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cuba opened this issue Sep 27, 2023 · 5 comments · Fixed by brave/brave-core#20315
Closed

Add brave-core debounce layers for iOS #33275

cuba opened this issue Sep 27, 2023 · 5 comments · Fixed by brave/brave-core#20315
Assignees
@cuba
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality privacy/debounce URL debouncer QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPad QA Pass - iPhone QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.64.x - Release

Comments

@cuba
Copy link

cuba commented Sep 27, 2023 •
edited
Loading

Description

Debounce in iOS is using custom code. Let's use the code in brave-core instead.

Test strategy

  1. Test the debouncing feature in desktop here
@cuba cuba added OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 27, 2023
@cuba cuba self-assigned this Sep 27, 2023
@cuba cuba mentioned this issue Sep 27, 2023
Merged
25 tasks
@cuba cuba added OS/iOS Fixes related to iOS browser functionality QA/Yes labels Sep 27, 2023
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Feb 6, 2024
@btlechowski
Copy link

Verified with

Brave 1.64.91 Chromium: 122.0.6261.94 (Official Build) beta (64-bit)
Revision 939586e20d208404b83713ea05cf5f6fa7fe3dd5
OS Linux

Default

image

Base64

image

Regex

image

Regex (multi)

image

@LaurenWags
Copy link
Member

LaurenWags commented Mar 4, 2024 •
edited
Loading

Verified with

Brave | 1.64.90 Chromium: 122.0.6261.94 (Official Build) beta (x86_64)
-- | --
Revision | 726c6970a1e9c057c69d80e03ad95a7c561fbfe7
OS | macOS Version 13.6.4 (Build 22G513)

Debouncing is enabled by default, to test the disabled cases, need to update brave://flags/#brave-debounce to disabled and relaunch browser. Note, currently the "Disabled" cases need to be updated on the test page (however per discussions the error I get below does show that things are working as expected).

Default

Enabled Disabled
Default Screenshot 2024-03-04 at 4 06 17 PM

Base64

Enabled Disabled
Base 64 Screenshot 2024-03-04 at 4 06 26 PM

Regex

Enabled Disabled
Regex Screenshot 2024-03-04 at 4 06 39 PM

Regex (multi)

Enabled Disabled
Regex - multi Screenshot 2024-03-04 at 4 06 54 PM

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 4, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 6, 2024
@hffvld
Copy link
Contributor

hffvld commented Mar 6, 2024 •
edited
Loading

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP21.240119.009 release-keys
Brave build: 1.64.95 
Chromium: 122.0.6261.94 (Official Build) beta (64-bit)

STEPS:

  1. Follow the steps from Add brave-core debounce layers for iOS #33275 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the results are correct
Galaxy Tab S8 / Tablet
Enabled Default Base64 Regex Regex (multi)
1 2 3 4 5
Disabled Default Base64 Regex Regex (multi)
1 2 3 4 5
Pixel 7 / Phone
Enabled Default Base64 Regex Regex (multi)
1 2 3 4 5
Disabled Default Base64 Regex Regex (multi)
1 2 3 4 5

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 6, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.64.104 Chromium: 123.0.6312.46 (Official Build) (64-bit)
-- | --
Revision | 0ca3d372cf8aab96fafdd75f5c5c8d2012bc0cc6
OS | Windows 11 Version 23H2 (Build 22631.3296)

brave://flags/#brave-debounce

Enabled Disabled
image image

Debouncing

Enabled Disabled
image image

Base64

Enabled Disabled
image image

Regex

Enabled Disabled
image image

Regex (multi)

Enabled Disabled
image image

@kjozwiak kjozwiak mentioned this issue Mar 20, 2024
Closed
25 tasks
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 22, 2024
@hffvld hffvld mentioned this issue Mar 22, 2024
Closed
@hffvld
Copy link
Contributor

hffvld commented Mar 22, 2024

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 / iOS 17.4
- iPad Air / iPadOS 16.7.2
Brave build: 1.64 (109)
BraveCore: 1.64.109 (123.0.6312.58)

Filed follow-up issue #37026

STEPS:

  1. Launch Brave
  2. Go to https://dev-pages.brave.software/navigation-tracking/debouncing.html
  3. Tap Run for the Default test case > Verify results
  4. Open NTP > Go to https://dev-pages.brave.software/navigation-tracking/debouncing.html
  5. Tap Run for the Base64 test case > Verify results
  6. Open NTP > Go to https://dev-pages.brave.software/navigation-tracking/debouncing.html
  7. Tap Run for the Regex test case > Verify results
  8. Open NTP > Go to https://dev-pages.brave.software/navigation-tracking/debouncing.html
  9. Tap Run for the Regex (multi) test case > Verify results

ACTUAL RESULTS:

  • Verified that the results are correct
iPhone
Enabled Default Base64 Regex Regex (multi)
1 2 3 4 5
Disabled Default Base64 Regex Regex (multi)
1 2 3 4 5
iPad
Enabled Default Base64 Regex Regex (multi)
1 2 3 4 5
Disabled Default Base64 Regex Regex (multi)
1 2 3 4 5

@hffvld hffvld removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cuba cuba

Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality privacy/debounce URL debouncer QA Pass - Android ARM QA Pass - Android Tab QA Pass - iPad QA Pass - iPhone QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

Add DebounceService for iOS brave/brave-core
6 participants
@cuba @LaurenWags @btlechowski @brave-builds @MadhaviSeelam @hffvld