Brave News onboarding card displaying on unsupported regions (not respecting locale check)

[kjozwiak]

Description

While verifying/running through brave/brave-core#20197 on desktop, noticed that the Brave News onboarding card was still being displayed for fr-FR & de-DE even though they technically shouldn't. Currently on desktop, we're only displaying the Brave News animation/card on certain locales as per https://github.com/brave/brave-core/blob/master/components/brave_news/browser/locales_helper.cc#L39.

I'm assuming we'll want to do the following:

• on new installs while on an unsupported region, don't display the Brave News onboarding card via the NTP
  • assuming users can still enable this on their own via Hamburger Menu -> Settings -> Brave News
• do nothing for users who are in unsupported regions but already enabled Brave News

Steps to reproduce

Prerequisites before launching Brave: Set the OS language to either French - France or German - Deutschland

1. install 1.60.38 Chromium 117.0.5938.88
2. launch Brave and run through onboarding (doesn't really matter what you select/skip)
3. you'll notice that the Brave News card is still visible for unsupported regions

QA will basically need to run through the same STR/Cases outlined via brave/brave-core#20197 (comment) once the issue has been resolved/fixed.

Actual result

Example	Example	Example

Expected result

The Brave News onboarding card shouldn't be displayed for unsupported regions. Quick example of Desktop working:

Example	Example	Example

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? Yes
• Can you reproduce this issue with the current Play Store Beta version? Yes
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
• Android version: Android 14

Brave version

Brave | 1.60.38 Chromium: 117.0.5938.88 (Official Build) canary (64-bit)
--- | ---
Revision | 89f7ea7a01a3ab15163916a9441c473ab1021372
OS | Android 14; Build/U1B1.230908.003; 34; REL

Website problems only

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Additional information

[Uni-verse]

Verified on Samsung Galaxy S21 using the following version:

Brave	1.61.93 Chromium: 119.0.6045.199 (Official Build) (64-bit) 
Revision	f707e858dc981208907fd0be3314d081a5dc86ae
OS	Android 13; Build/TP1A.220624.014; 33; REL

• Verified STR in Brave News: new regions enable pref by default (fr_FR and de_DE) #32416 (comment).
• Verified Brave News opt-in card is shown in NTP for French and German locales.
• Verified news feed is shown after opting in.

Example	Example	Example