Skip to content

Brave News: new region enable pref by default (es_AR) #33251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
petemill opened this issue Sep 25, 2023 · 6 comments · Fixed by brave/brave-core#20286
Closed

Brave News: new region enable pref by default (es_AR) #33251

petemill opened this issue Sep 25, 2023 · 6 comments · Fixed by brave/brave-core#20286
Assignees
@petemill
Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.58.x - Release #6

Comments

@petemill
Copy link
Member

petemill commented Sep 25, 2023 •
edited
Loading

Add es_AR to the list of locales that will result in the user having News enabled by default.

Test Plan

  1. Set default region and language in OS to es_AR
  2. Run fresh profile
  3. Verify locale at brave://rewards-internals/ and click the "Ad diagnostics", check locale field is es_AR
  4. Confirm Brave News shows by default on the NTP
image
@petemill petemill added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 25, 2023
@petemill petemill self-assigned this Sep 25, 2023
@petemill petemill mentioned this issue Sep 25, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 27, 2023
This was referenced Sep 27, 2023
Merged
Merged
@kjozwiak kjozwiak added feature/brave-news formerly brave-today and removed OS/Android Fixes related to Android browser functionality labels Sep 27, 2023
@kjozwiak
Copy link
Member

Removing OS/Android as the above won't be verifiable till #33267 is addressed. Once #33267 is fixed, we'll run through the same STR/Cases that were completed via brave/brave-core#20197 (comment).

@kjozwiak
Copy link
Member

The above requires 1.58.134 or higher for 1.58.x verification 👍

@kjozwiak
Copy link
Member

@LaurenWags for the above, we can just use a single entry within the release notes to mention that Brave News was enabled via #32416 and the above.

@stephendonner stephendonner added QA/Test-All-Platforms QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2023
@stephendonner
Copy link

Verification PASSED using

Brave | 1.58.134 Chromium: 117.0.5938.140 (Build oficial) (x86_64)
-- | --
Revisión | b0942733988798287d53c996e097f756d614a059
SO | macOS Versión 14.1 (Fase 23B5046f)

Steps:

  1. set my macOS region & language to Argentina and es_AR, respectively
  2. installed 1.58.134
  3. launched Brave
  4. confirmed Spanish (Argentina) language in brave://settings/languages
  5. opened brave://rewards-internals/
  6. clicked on the Ad diagnostics tab
  7. confirmed Locale: es-AR string
  8. opened a new-tab page
  9. confirmed locale-specific sources (and a few others, like BBC News, in English, which I believe is expected) displayed
example example example example example example
Captura de pantalla 2023-09-28 a la(s) 01 16 37 Captura de pantalla 2023-09-28 a la(s) 01 28 31 Captura de pantalla 2023-09-28 a la(s) 01 32 39 Captura de pantalla 2023-09-28 a la(s) 01 36 22 Captura de pantalla 2023-09-28 a la(s) 01 36 25 Captura de pantalla 2023-09-28 a la(s) 01 36 31

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2023
@btlechowski
Copy link

Verification PASSED

Brave 1.58.134 Chromium: 117.0.5938.140 (Official Build) (64-bit)
Revision b0942733988798287d53c996e097f756d614a059
OS Linux

es_AR - PASSED

Steps:

  1. set my macOS region & language to France and es_AR, respectively
  2. installed 1.58.134
  3. launched Brave
  4. confirmed español (Latinoamérica) language in brave://settings/languages
  5. opened brave://rewards-internals/
  6. clicked on the Ad diagnostics tab
  7. confirmed Locale: es_AR string
  8. opened a new-tab page
  9. opted-in to Brave News
  10. confirmed locale-specific sources displayed
image image image image

@LaurenWags LaurenWags mentioned this issue Sep 28, 2023
Closed
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 28, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 28, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.58.135 Chromium: 117.0.5938.140 (Build oficial) (64 bits)
-- | --
Revisión | 325e8592cad8c6badb656cab238b722ae46bf7bc
SO | Windows 11 Version 22H2 (Build 22621.2283)

Steps:

  1. set my Win region & language to Argentina and `Espanol Argentina¨, respectively
  2. installed 1.58.135
  3. launched Brave
  4. confirmed espanol language in brave://settings/languages
  5. opened brave://rewards-internals/
  6. clicked on the Ad diagnostics tab
  7. confirmed Locale: es-AR string
  8. opened a new-tab page
  9. confirmed locale-specific sources (and a few others, like BBC World News, in English, which I believe is expected) displayed
example example example example example example
image image image image image image

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 28, 2023
@MadhaviSeelam MadhaviSeelam mentioned this issue Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.58.x - Release #6
Development

Successfully merging a pull request may close this issue.

News: add "es_AR" to default region list brave/brave-core
6 participants
@stephendonner @petemill @kjozwiak @btlechowski @brave-builds @MadhaviSeelam