Skip to content

Sometimes credentials are not returned if an error happens during refresh_order_credentials #32924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bsclifton opened this issue Sep 12, 2023 · 6 comments · Fixed by brave/brave-core#20192
Closed

Sometimes credentials are not returned if an error happens during refresh_order_credentials #32924

bsclifton opened this issue Sep 12, 2023 · 6 comments · Fixed by brave/brave-core#20192
Assignees
@bsclifton @evq
Labels
feature/SKUs OS/Android Fixes related to Android browser functionality OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release #4

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 12, 2023 •
edited
Loading

Test plan

See brave/brave-core#20192

Description

Folks that purchase VPN or link their iOS/Android purchase can get a time limited v2 credential from account.brave.com

As they approach expiry (within 5 days) - a check is made which calls refresh_order_credentials. If this encounters an error, no credentials are returned.
@bsclifton bsclifton added OS/Android Fixes related to Android browser functionality OS/Desktop feature/SKUs labels Sep 12, 2023
@bsclifton bsclifton mentioned this issue Sep 13, 2023
Closed
25 tasks
@bsclifton bsclifton added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Sep 14, 2023
bsclifton added a commit to brave/brave-core that referenced this issue Sep 15, 2023
@bsclifton
Remove the continue on error in matching_order_credential_summary
d79aa15 
Fixes brave/brave-browser#32924

Also updates the credential v1 logic - matches the tlv2 conditions.
@bsclifton bsclifton mentioned this issue Sep 15, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.60.x - Nightly milestone Sep 16, 2023
This was referenced Sep 17, 2023
Merged
Merged
@bsclifton bsclifton added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Sep 18, 2023
@bsclifton bsclifton changed the title No credentials are returned if an error happens during refresh_order_credentials Sometimes credentials are not returned if an error happens during refresh_order_credentials Sep 18, 2023
@kjozwiak
Copy link
Member

The above requires 1.58.129 or higher for 1.58.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 20, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.58.129 Chromium: 117.0.5938.88 (Official Build) (64-bit)
-- | --
Revision | 0ab74dc5473bd9dcd0a85653872988a5655aff6b
OS | Windows 10 Version 22H2 (Build 19045.3448)

Ensure new purchases work - PASSED

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered basic-auth credentials for staging
  5. entered [email protected] into the textfield
  6. clicked Get login link
  7. clicked Log in to Brave in the resulting email
  8. clicked Start free trial beside Brave VPN
  9. completed Stripe checkout
  10. connect to Brave VPN
  11. disconnect from Brave VPN/switch servers

Confirmed You have active credentials loaded! banner and working credentials. Also confirmed ability to switch servers, and cleanly disconnect from Brave VPN

Connected Disconnected
image image

Existing users (recent purchase) - PASSED

Steps:

  1. installed 1.60.38
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered basic-auth credentials for staging
  5. entered [email protected]
  6. clicked Get login link
  7. in the resulting email, clicked Log in to Brave
  8. clicked on Refresh Brave VPN button
  9. connected to Brave VPN (updated, for me Brave VPN was not in auto connected state, I had to connect it manually)
  10. switched servers/region
  11. disconnected from Brave VPN
Refresh Brave VPN Loading... Connected Switch region Disconnected
image image image image image

Confirmed You have active credentials loaded! banner and working credentials, using previously set up account. Also confirmed ability to switch servers, and cleanly disconnect from Brave VPN

@LaurenWags LaurenWags mentioned this issue Sep 20, 2023
Closed
@stephendonner
Copy link

stephendonner commented Sep 20, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.58.129 Chromium: 117.0.5938.88 (Official Build) (x86_64)
-- | --
Revision | 0ab74dc5473bd9dcd0a85653872988a5655aff6b
OS | macOS Version 11.7.10 (Build 20G1427)

Ensure new purchases work - PASSED

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered basic-auth credentials for staging
  5. entered [email protected] into the textfield
  6. clicked Get login link
  7. clicked Log in to Brave in the resulting email
  8. clicked Start free trial beside Brave VPN
  9. completed Stripe checkout
  10. connected to Brave VPN
  11. switched servers
  12. disconnected from Brave VPN
Connected Disconnected
Screen Shot 2023-09-20 at 10 13 10 AM Screen Shot 2023-09-20 at 10 13 29 AM

Existing users (recent purchase) - PASSED

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered [email protected]
  5. clicked Get login link
  6. in the resulting email, clicked Log in to Brave
  7. clicked on Refresh Brave VPN button
  8. clicked on the VPN button
  9. toggled from Disconnected to Connected
  10. switched servers/region
  11. disconnected from Brave VPN
Refresh Brave VPN Loading... Connected Switch region Disconnected
Screen Shot 2023-09-20 at 10 28 43 AM Screen Shot 2023-09-20 at 10 29 09 AM Screen Shot 2023-09-20 at 10 29 34 AM Screen Shot 2023-09-20 at 10 29 47 AM Screen Shot 2023-09-20 at 10 30 14 AM

Existing users - within 5 days of renewal - PASSED

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered [email protected] into the textfield
  5. clicked Get login link
  6. in the resulting email, clicked on Log in to Brave
  7. confirmed You have active credentials loaded! banner
  8. connected to Brave VPN
  9. confirmed I could switch servers
  10. disconnected from Brave VPN
  11. opened brave://skus-internals
  12. clicked on Fetch VPN state
  13. clicked on Fetch SKUs state
  14. collapsed the large creds block, and looked for unblinded_creds

Confirmed account due for renewal on the 24th of this month had enough daily credentials to get to the expiration/renewal date of 9-25, UTC

example example example example example example
Screen Shot 2023-09-20 at 10 53 47 AM Screen Shot 2023-09-20 at 10 54 04 AM Screen Shot 2023-09-20 at 10 54 08 AM Screen Shot 2023-09-20 at 10 54 20 AM Screen Shot 2023-09-20 at 10 56 20 AM Screen Shot 2023-09-20 at 10 59 20 AM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 20, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.58.129 Chromium: 117.0.5938.88 (Official Build) (64-bit)
-- | --
Revision | 0ab74dc5473bd9dcd0a85653872988a5655aff6b
OS | Windows 11 Version 22H2 (Build 22621.2283)

Ensure new purchases work - PASSED

Steps:
  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered basic-auth credentials for staging
  5. entered [email protected] into the textfield
  6. clicked Get login link
  7. clicked Log in to Brave in the resulting email
  8. clicked Start free trial beside Brave VPN
  9. completed Stripe checkout
  10. connect to Brave VPN
  11. disconnect from Brave VPN/switch servers
  12. Confirmed You have active credentials loaded! banner and working credentials. Also confirmed ability to switch servers, and cleanly disconnect from Brave VPN
connected disconnected
image image

Existing users (recent purchase) - PASSED

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered [email protected]
  5. clicked Get login link
  6. in the resulting email, clicked Log in to Brave
  7. clicked on Refresh Brave VPN button
  8. clicked on the VPN button
  9. toggled from Disconnected to Connected
  10. switched servers/region
  11. disconnected from Brave VPN
Refresh Brave VPN Loading... Connected Switch region Disconnected
image image image image image

@stephendonner
Copy link

Verified PASSED using

Brave | 1.58.129 Chromium: 117.0.5938.88 (Official Build) (64-bit)
-- | --
Revision | 0ab74dc5473bd9dcd0a85653872988a5655aff6b
OS | Windows 10 Version 22H2 (Build 19045.3448)

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered [email protected]
  5. clicked Get login link
  6. in the resulting email, clicked on Log in to Brave
  7. confirmed I saw You have active credentials loaded! banner
  8. connected to Brave VPN
  9. confirmed I could switch servers/regions
  10. disconnected from Brave VPN
  11. opened brave://skus-internals
  12. clicked on Fetch VPN state
  13. clicked on Fetch SKUs state
  14. collapsed the creds section
  15. looked for the final day of credentials
  16. cross-checked the above with the expires_at timestamp value

Confirmed the final-day credential and the expires_at match its expiration/renewal date of 9-22 (23 in UTC...)

example example example example example example example
image (6) image (7) image (8) image (9) image (10) image (11) image (12)

@stephendonner
Copy link

stephendonner commented Sep 20, 2023 •
edited
Loading

Verification PASSED using

Brave 1.58.129, Chromium 117.0.5938.88
Android 9.0, arm64
Google Pixel XL

New subscription - Google Play Store/IAP card - PASSED

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. tapped on the 3-dots menu
  4. tapped Settings
  5. tapped About Brave
  6. tapped the Application version section a few times to enable Developer options
  7. tapped on Developer options
  8. tapped on QA Preferences
  9. entered the code
  10. enabled Brave VPN
  11. tapped on the monthly option in the test card, to purchase Brave VPN
  12. tapped Install VPN Profile
  13. tapped OK at the connection-request dialog
  14. confirmed VPN is now enabled dialog
  15. loaded whatismyipaddress.com

Confirmed I was successfully connected to Brave VPN

example example example example example example example
Screenshot_20230920-144335 Screenshot_20230920-144803 Screenshot_20230920-144809 Screenshot_20230920-141606 Screenshot_20230920-141614 Screenshot_20230920-141619 Screenshot_20230920-142836

New subscription - account.bravesoftware.com - PASSED

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. entered basic-auth username/password
  5. entered [email protected]
  6. clicked Get login link
  7. in the resulting email, clicked Log in to Brave
  8. clicked Start free trial
  9. completed Stripe checkout
  10. confirmed Success! / You have active credentials loaded! banners
  11. tapped on the 3-dots menu
  12. tapped on Brave VPN
  13. tapped Install VPN Profile
  14. tapped OK
  15. loaded whatismyipaddress.com

Confirmed I was connected to Brave VPN

example example example example example
Screenshot_20230920-153154 Screenshot_20230920-153209 Screenshot_20230920-153325 Screenshot_20230920-153340 Screenshot_20230920-153346
example example example example example
Screenshot_20230920-153401 Screenshot_20230920-153406 Screenshot_20230920-153410 Screenshot_20230920-153440 Screenshot_20230920-153450

Existing users (recent purchase) - PASSED

Desktop

Steps:

  1. installed 1.59.93
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. purchased, configured, and connected to Brave VPN using [email protected] as the account
example example example example example example example
Screenshot 2023-09-20 at 2 58 03 PM Screenshot 2023-09-20 at 2 58 06 PM Screenshot 2023-09-20 at 2 58 43 PM Screenshot 2023-09-20 at 2 58 46 PM Screenshot 2023-09-20 at 2 58 52 PM Screenshot 2023-09-20 at 2 59 04 PM Screenshot 2023-09-20 at 2 59 36 PM

Android

Steps:

  1. installed 1.58.129
  2. launched Brave
  3. loaded account.bravesoftware.com
  4. logged in to the [email protected] account
  5. confirmed and clicked on the Refresh Brave VPN button
  6. waited
  7. confirmed Success! / You have active credentials loaded! banner
  8. tapped on the Brave VPN menu in the top-level app menu (3-dots menu)
  9. tapped Install VPN Profile
  10. tapped OK
  11. loaded whatismyipaddress.com

Confirmed I was connected to Brave VPN

example example example example example example example
Screenshot_20230920-150740 Screenshot_20230920-150757 Screenshot_20230920-150821 Screenshot_20230920-150852 Screenshot_20230920-150857 Screenshot_20230920-151154 Screenshot_20230920-151203

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

@evq evq

Labels
feature/SKUs OS/Android Fixes related to Android browser functionality OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.58.x - Release #4
Development

Successfully merging a pull request may close this issue.

SKU sdk - update credential matching logic brave/brave-core
8 participants
@stephendonner @kjozwiak @bsclifton @evq @LaurenWags @GeetaSarvadnya @brave-builds @MadhaviSeelam