Skip to content

"Back gesture" on Android 14 is closing Brave, and Brave is crashing sometimes because of that #31939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hffvld opened this issue Jul 28, 2023 · 3 comments · Fixed by brave/brave-core#19766
Assignees
Labels
bug crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@hffvld
Copy link
Contributor

hffvld commented Jul 28, 2023

Description

Back gesture on Android 14 is closing Brave, and Brave is crashing sometimes because of that

--------- beginning of crash
2023-07-27 17:10:38.563 15467-15467 chromium                pid-15467                            W  [0727/171038.563508:WARNING:exception_snapshot_linux.cc(263)] fpsimd not found
2023-07-27 17:10:40.903 15482-15482 chromium                pid-15482                            I  [INFO:policy_logger.cc(142)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(273) Deferring CBCM Controller Initialization until it is unblocked.
2023-07-27 17:10:41.352 15482-15482 chromium                pid-15482                            I  [INFO:mod.rs(70)]   skus::sdk: skus sdk initialized, environment: production, version: 35fdc4518c3be-modified
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/sdk/mod.rs:70
2023-07-27 17:10:41.352 15482-15482 chromium                pid-15482                            V  [VERBOSE1:kv.rs(126)]   skus::storage::kv: got orders, orders: None
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/storage/kv.rs:126
                                                                                                        in skus::storage::kv::get_orders with self=NativeClient
                                                                                                        in skus::sdk::credentials::matching_credential_summary with self=SDK domain="vpn.brave.com"
2023-07-27 17:10:41.455 15482-15660 chromium                pid-15482                            E  [ERROR:socket_posix.cc(147)] bind() failed: Address already in use (98)
2023-07-27 17:10:41.455 15482-15660 chromium                pid-15482                            E  [ERROR:unix_domain_server_socket_posix.cc(86)] Could not bind unix domain socket to chrome_devtools_remote (with abstract namespace): Address already in use (98)
2023-07-27 17:10:41.457 15482-15561 chromium                pid-15482                            E  [ERROR:directory_reader_posix.cc(42)] opendir /data/user/0/com.brave.browser_nightly/cache/Crashpad/attachments/26797d0b-0552-4945-8951-bbd45efc4fe3: No such file or directory (2)
2023-07-27 17:10:58.551 15753-15753 chromium                pid-15753                            W  [0727/171058.551346:WARNING:exception_snapshot_linux.cc(263)] fpsimd not found
2023-07-27 17:11:02.001 15781-15781 chromium                pid-15781                            I  [INFO:policy_logger.cc(142)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(273) Deferring CBCM Controller Initialization until it is unblocked.
2023-07-27 17:11:02.438 15781-15781 chromium                pid-15781                            I  [INFO:mod.rs(70)]   skus::sdk: skus sdk initialized, environment: production, version: 35fdc4518c3be-modified
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/sdk/mod.rs:70
2023-07-27 17:11:02.439 15781-15781 chromium                pid-15781                            V  [VERBOSE1:kv.rs(126)]   skus::storage::kv: got orders, orders: None
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/storage/kv.rs:126
                                                                                                        in skus::storage::kv::get_orders with self=NativeClient
                                                                                                        in skus::sdk::credentials::matching_credential_summary with self=SDK domain="vpn.brave.com"
2023-07-27 17:11:03.570 15781-15977 chromium                com.brave.browser_nightly            E  [ERROR:socket_posix.cc(147)] bind() failed: Address already in use (98)
2023-07-27 17:11:03.570 15781-15977 chromium                com.brave.browser_nightly            E  [ERROR:unix_domain_server_socket_posix.cc(86)] Could not bind unix domain socket to chrome_devtools_remote (with abstract namespace): Address already in use (98)
2023-07-27 17:11:03.573 15781-15876 chromium                com.brave.browser_nightly            E  [ERROR:directory_reader_posix.cc(42)] opendir /data/user/0/com.brave.browser_nightly/cache/Crashpad/attachments/40d49a2e-3e1b-4e4a-a56e-211bfdd6de01: No such file or directory (2)
2023-07-27 17:11:07.130 15991-15991 chromium                pid-15991                            W  [0727/171107.130434:WARNING:exception_snapshot_linux.cc(263)] fpsimd not found
2023-07-27 17:11:08.839 15999-15999 chromium                pid-15999                            I  [INFO:policy_logger.cc(142)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(273) Deferring CBCM Controller Initialization until it is unblocked.
2023-07-27 17:11:09.272 15999-15999 chromium                pid-15999                            I  [INFO:mod.rs(70)]   skus::sdk: skus sdk initialized, environment: production, version: 35fdc4518c3be-modified
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/sdk/mod.rs:70
2023-07-27 17:11:09.272 15999-15999 chromium                pid-15999                            V  [VERBOSE1:kv.rs(126)]   skus::storage::kv: got orders, orders: None
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/storage/kv.rs:126
                                                                                                        in skus::storage::kv::get_orders with self=NativeClient
                                                                                                        in skus::sdk::credentials::matching_credential_summary with self=SDK domain="vpn.brave.com"
2023-07-27 17:11:10.296 15999-16179 chromium                com.brave.browser_nightly            E  [ERROR:socket_posix.cc(147)] bind() failed: Address already in use (98)
2023-07-27 17:11:10.296 15999-16179 chromium                com.brave.browser_nightly            E  [ERROR:unix_domain_server_socket_posix.cc(86)] Could not bind unix domain socket to chrome_devtools_remote (with abstract namespace): Address already in use (98)
2023-07-27 17:11:10.296 15999-16081 chromium                com.brave.browser_nightly            E  [ERROR:directory_reader_posix.cc(42)] opendir /data/user/0/com.brave.browser_nightly/cache/Crashpad/attachments/396feac9-fa8c-42d2-9330-ed62e4747d7c: No such file or directory (2)
2023-07-27 17:11:11.731 16194-16194 chromium                [browser_nightly]                    W  [0727/171111.730870:WARNING:exception_snapshot_linux.cc(263)] fpsimd not found
2023-07-27 17:11:14.054 16228-16228 chromium                pid-16228                            I  [INFO:policy_logger.cc(142)] :components/enterprise/browser/controller/chrome_browser_cloud_management_controller.cc(273) Deferring CBCM Controller Initialization until it is unblocked.
2023-07-27 17:11:14.506 16228-16228 chromium                pid-16228                            I  [INFO:mod.rs(70)]   skus::sdk: skus sdk initialized, environment: production, version: 35fdc4518c3be-modified
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/sdk/mod.rs:70
2023-07-27 17:11:14.506 16228-16228 chromium                pid-16228                            V  [VERBOSE1:kv.rs(126)]   skus::storage::kv: got orders, orders: None
                                                                                                        at ../../brave/components/skus/browser/rs/lib/src/storage/kv.rs:126
                                                                                                        in skus::storage::kv::get_orders with self=NativeClient
                                                                                                        in skus::sdk::credentials::matching_credential_summary with self=SDK domain="vpn.brave.com"
2023-07-27 17:11:15.271 16228-16407 chromium                pid-16228                            E  [ERROR:socket_posix.cc(147)] bind() failed: Address already in use (98)
2023-07-27 17:11:15.271 16228-16407 chromium                pid-16228                            E  [ERROR:unix_domain_server_socket_posix.cc(86)] Could not bind unix domain socket to chrome_devtools_remote (with abstract namespace): Address already in use (98)
2023-07-27 17:11:15.271 16228-16306 chromium                pid-16228                            E  [ERROR:directory_reader_posix.cc(42)] opendir /data/user/0/com.brave.browser_nightly/cache/Crashpad/attachments/5dc3428a-8fd2-4c15-addc-b72d8afca47d: No such file or directory (2)

Steps to reproduce

  1. Launch Brave
  2. Open, for example, www.wikipedia.org > Open any article
  3. Use any link in the article to go forward
  4. Now use Back gesture to return to the previous page > Observe

Actual result

  1. Every time when trying to return to the previous page, Brave is closing instead.
  2. Sometime Brave is crashing when using Back gesture.

I think this is not a C116 issue, because the same Brave build is working fine on Pixel 6 with Android 13.

timestamp_17-10-48_17-11-20.mp4

Expected result

  1. Back gesture must work as expected, a user must be able to return to the previous page
  2. Brave must not crash when using Back gesture

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 7 [phone]
  • Android version: Android 14 [panther_beta-user 14 UPB4.230623.007 release-keys]

Brave version

Brave build: 1.58.52
Chromium: 116.0.5845.51 (Official Build) canary (64-bit)
Revision: d5ec999

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

The above requires 1.57.50 or higher for 1.57.x verification 👍

@kjozwiak
Copy link
Member

@Uni-verse @vlad-hoff we'll also need to quickly verify the gesturing back/forward is also working on Android 13 and ensuring nothing obvious as regressed.

@hffvld
Copy link
Contributor Author

hffvld commented Aug 18, 2023

Verified on Pixel 6 and Pixel 7 using version(s):

Device/OS: 
- Pixel 6 [oriole-user 13 TQ3A.230805.001 release-keys]
- Pixel 7 [panther_beta-user 14 UPB5.230623.005 release-keys]
Brave build: 1.57.50
Chromium: 116.0.5845.96 (Official Build) (64-bit) 
Revision: dd68ca599736ea1ec946e2e9def70f3c705895e1

Fresh install - PASS

STEPS:

  1. Followed the steps from "Back gesture" on Android 14 is closing Brave, and Brave is crashing sometimes because of that #31939 (comment) with Android 14 device > Verify
  2. Repeat these steps with Android 13 device > Verify that there is no regression occurred

ACTUAL RESULTS:

  • Verified that using Back gesture while on NTP is collapsing Brave as expected
  • Verified that using Back gesture is returning to the previous screen. This is working for the websites and Brave settings
  • Verified that Brave is not crashing

Android 13

timestamp_16-16-59_16-18-34.mp4

Android 14

timestamp_16-55-01_16-56-00.mp4
Upgrade flow - PASS

STEPS:

  1. Followed the steps from "Back gesture" on Android 14 is closing Brave, and Brave is crashing sometimes because of that #31939 (comment) with Android 14 device
  2. Repeat these steps with Android 13 device to verify that there is no regression occurred

ACTUAL RESULTS:

  • Verified that using Back gesture while on NTP is collapsing Brave as expected
  • Verified that using Back gesture is returning to the previous screen. This is working for the websites and Brave settings
  • Verified that Brave is not crashing

Android 13

timestamp_16-26-39_16-27-58.mp4

Android 14

timestamp_16-49-44_16-51-44.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants