Skip to content

Selecting All networks import hardware wallet screen stops showing balance #30484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srirambv opened this issue May 22, 2023 · 2 comments · Fixed by brave/brave-core#20872
Closed

Comments

@srirambv
Copy link
Contributor

Description

Selecting All networks import hardware wallet screen stops showing balance

Steps to Reproduce

  1. Connect hardware wallet
  2. Select any network and select All network
  3. Balance is hidden

Actual result:

Solana EVM Filecoin
brave_PqxangOVqb brave_jg8pnUgdcp brave_tb7HAw48Ls

Expected result:

Hide All networks when not applicable.

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Windows 11 Version 22H2 (Build 22621.1702)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Note: Also showing All networks for Solana and Filecoin doesn't make sense

cc: @Douglashdaniel @jamesmudgett @josheleonard

@HEagle18
Copy link

HEagle18 commented Jun 9, 2023

@kleantzogu might be worth thinking about for wallet 2.0 designs.

@HEagle18 HEagle18 moved this to Backlog in Web3 Jun 9, 2023
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Nov 6, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Nov 7, 2023
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 7, 2023
@srirambv
Copy link
Contributor Author

srirambv commented Jan 3, 2024

Verification passed on

Brave 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Revision 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS Windows 11 Version 23H2 (Build 22631.2861)
  • Verified steps from brave/brave-core#20872
  • Verified All Networks option is removed from import hardware wallet
  • Verified only selected Network types are listed when importing accounts via hardware wallet
Ethereum/EVM Solana Filecoin
brave_nHOoPOHMhQ brave_SPRJ2qOi4C brave_BHFdBz4GA5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants