Skip to content

Allow checking hardware wallet balance across all networks during import #29662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
josheleonard opened this issue Apr 12, 2023 · 1 comment · Fixed by brave/brave-core#18152
Closed
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include

Comments

@josheleonard
Copy link

Description

When importing a hardware wallet account, provide a network selector in the UI so that the account balance can be checked for networks other than the "default" for the account coin-type. (We already do this for Filecoin, EVM and SOL chain selectors missing)

Steps to Reproduce

  1. Select an EVM network such as BNB-Chain
  2. Navigate to the accounts page and click "import from hardware wallet"
  3. select Ethereum/EVM option
  4. connect the hardware device and view the list of accounts

Actual result:

Native asset ticket is not shown next to the balance
No UI is provided to select a different chain

Expected result:

UI is provided to select a different EVM chain
Native asset balance and ticker are updated when chain selection changes

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

After this change is made, the concept of a "default network" can be deprecated from desktop UI logic

@josheleonard josheleonard added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 12, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Apr 14, 2023
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Apr 14, 2023
@josheleonard josheleonard added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Apr 19, 2023
@josheleonard josheleonard self-assigned this Apr 19, 2023
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Apr 19, 2023
@josheleonard josheleonard removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Apr 19, 2023
@josheleonard josheleonard moved this from In Progress to In Review in Web3 Apr 19, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Apr 20, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 20, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS Windows 11 Version 22H2 (Build 22621.1702)
  • Verified steps from brave/brave-core#18152
  • Verified network filter is shown on import hardware wallet screen
  • Verified able to view balance based on network and derivation path
  • Verified for EVM/Solana/Filecoin
  • Encountered #30484
Solana EVM Filecoin
brave_bNOtRFHajH brave_uFiytubOgz brave_9ofnSMPjnf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants