"Don't upgrade connections to HTTPS (disabled)" is not working

[hffvld]

Description

"Don't upgrade connections to HTTPS (disabled)" is not working

Steps to reproduce

1. Launch Brave > Hamburger Menu
2. Settings > Brave Shields & privacy
3. Upgrade connections to HTTPS > Choose Don't upgrade connections to HTTPS (disabled)
4. Return to NTP and open http://https-everywhere.badssl.com/ > Observe

Actual result

When Don't upgrade connections to HTTPS (disabled) setting is applied, pages are still opened and upgraded to HTTPS. The only way to disable forced upgrade to HTTPS is to turn off Shields. The same issue was observed on Nightly and Beta build, but not on Prod.

timestamp_10-20-44_10-21-24.mp4

Expected result

No HTTPS upgrade must be triggered when Don't upgrade connections to HTTPS (disabled) setting is applied

Issue reproduces how often

Easily reproduced

Version/Channel Information:

• Can you reproduce this issue with the current Play Store version? No
• Can you reproduce this issue with the current Play Store Beta version? Yes
• Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Pixel 7 [phone]
• Android version: Android 14 [panther_beta-user 14 UPB2.230407.014 release-keys]

Brave version

Brave build: 1.53.47
Chromium: 114.0.5735.26 (Official Build) canary (64-bit)
Revision: 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}

Website problems only

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Additional information

[kjozwiak]

The above requires 1.52.115 or higher fort 1.52.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.52.115 Chromium: 114.0.5735.53 (Official Build) (64-bit)
-- | --
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Windows 10 Version 22H2 (Build 19045.2965)

• Verified the STR from the description
• Reproduced the issue on 1.52.113

1.52.113	1.52.115

[stephendonner]

Verified PASSED using

Brave	1.52.115 Chromium: 114.0.5735.53 (Official Build) (x86_64)
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	macOS Version 11.7.7 (Build 20G1345)

• Verified the STR from the description
• Reproduced the issue on 1.52.113

1.52.115	1.52.113

[kjozwiak]

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.52.115 Chromium: 114.0.5735.53 (Official Build) (64-bit)
--- | ---
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Android 13; Build/UPB2.230407.014; 33; UpsideDownCake

Using the STR/Cases outlined via #30436 (comment), ensured that http://https-everywhere.badssl.com is not being upgraded when Don't upgrade connections to HTTPS (disabled) is set via brave://settings/shields as per the following:

1.51.121 Chromium 113.0.5672.163	1.52.115 Chromium: 114.0.5735.53

---

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.52.115 Chromium: 114.0.5735.53 (Official Build) (64-bit)
--- | ---
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Android 13; Build/TP1A.220624.014; 33; REL

Using the STR/Cases outlined via #30436 (comment), ensured that http://https-everywhere.badssl.com is not being upgraded when Don't upgrade connections to HTTPS (disabled) is set via brave://settings/shields as per the following:

1.51.121 Chromium 113.0.5672.163	1.52.115 Chromium: 114.0.5735.53

[btlechowski]

Verification passed on

Brave	1.52.115 Chromium: 114.0.5735.53 (Official Build) (64-bit)
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description
• Reproduced the issue on 1.52.113

1.52.115	1.52.113