Skip to content

Crash in NTP image decoding #29427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SergeyZhukovsky opened this issue Mar 30, 2023 · 0 comments · Fixed by brave/brave-core#17892
Closed

Crash in NTP image decoding #29427

SergeyZhukovsky opened this issue Mar 30, 2023 · 0 comments · Fixed by brave/brave-core#17892
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

SergeyZhukovsky commented Mar 30, 2023

I found that crash on 1.49.x. We can catch the OOM exception and just don't apply it instead of crashing if device have low memory. Nothing to verify there, so marking as QA/NO. I'm going to leave it in master os not many crashes like that.

java.lang.RuntimeException: An error occurred while executing doInBackground()
        at org.chromium.base.task.AsyncTask$NamedFutureTask.done(AsyncTask.java:486)
        at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
        at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
        at java.util.concurrent.FutureTask.run(FutureTask.java:242)
        at org.chromium.base.task.AsyncTask$NamedFutureTask.run(AsyncTask.java:474)
Caused by: java.lang.OutOfMemoryError: Failed to allocate a 14745612 byte allocation with 3669552 free bytes and 3MB until OOM
        at dalvik.system.VMRuntime.newNonMovableArray(Native Method)
        at android.graphics.BitmapFactory.nativeDecodeStream(Native Method)
        at android.graphics.BitmapFactory.decodeStreamInternal(BitmapFactory.java:726)
        at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:702)
        at org.chromium.chrome.browser.ntp_background_images.util.NTPUtil.getBitmapFromImagePath(NTPUtil.java:290)
        at org.chromium.chrome.browser.ntp_background_images.util.NTPUtil.getWallpaperBitmap(NTPUtil.java:268)
        at org.chromium.chrome.browser.ntp_background_images.util.FetchWallpaperWorkerTask.doInBackground(FetchWallpaperWorkerTask.java:74)
        at org.chromium.chrome.browser.ntp_background_images.util.FetchWallpaperWorkerTask.doInBackground(FetchWallpaperWorkerTask.java:23)
        at org.chromium.base.task.AsyncTask$1.call(AsyncTask.java:120)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        ... 1 more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants