Crash in Password manager

[SergeyZhukovsky]

We have such crash on our 1.49.x stable channel. I managed to replicate it on Pixel 6 Android 13 device following that article
https://stackoverflow.com/questions/74684221/android-application-crash-on-android-13. We need to fix and uplift to a stable channel.

1. Enable in your device Settings -> Display size & text -> Bold text.
2. Open Settings->Password Manager-><some website>.

Exception android.view.InflateException: Binary XML file line #39 in com.brave.browser:layout/0_resource_name_obfuscated: Attempt to invoke virtual method 'int android.graphics.Typeface.getWeight()' on a null object reference
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int android.graphics.Typeface.getWeight()' on a null object reference
  at com.google.android.material.resources.TypefaceUtils.maybeCopyWithFontWeightAdjustment (TypefaceUtils.java:57)
  at com.google.android.material.internal.CollapsingTextHelper.setCollapsedTypefaceInternal (CollapsingTextHelper.java:482)
  at com.google.android.material.internal.CollapsingTextHelper.setTypefaces (CollapsingTextHelper.java:465)
  at com.google.android.material.textfield.TextInputLayout.setEditText (TextInputLayout.java:1441)
  at com.google.android.material.textfield.TextInputLayout.addView (TextInputLayout.java:706)
  at android.view.ViewGroup.addView (ViewGroup.java:5048)
  at android.view.LayoutInflater.rInflate (LayoutInflater.java:1131)
  at android.view.LayoutInflater.rInflateChildren (LayoutInflater.java:1088)
  at android.view.LayoutInflater.rInflate (LayoutInflater.java:1130)
  at android.view.LayoutInflater.rInflateChildren (LayoutInflater.java:1088)
  at android.view.LayoutInflater.rInflate (LayoutInflater.java:1130)
  at android.view.LayoutInflater.rInflateChildren (LayoutInflater.java:1088)
  at android.view.LayoutInflater.rInflate (LayoutInflater.java:1130)
  at android.view.LayoutInflater.rInflateChildren (LayoutInflater.java:1088)
  at android.view.LayoutInflater.inflate (LayoutInflater.java:686)
  at android.view.LayoutInflater.inflate (LayoutInflater.java:538)
  at org.chromium.chrome.browser.password_entry_edit.CredentialEditFragmentView.onCreateView (CredentialEditFragmentView.java:42)
  at androidx.fragment.app.Fragment.performCreateView (Fragment.java:3108)
  at androidx.fragment.app.FragmentStateManager.createView (FragmentStateManager.java:557)
  at androidx.fragment.app.FragmentStateManager.moveToExpectedState (FragmentStateManager.java:272)
  at androidx.fragment.app.FragmentManager.executeOpsTogether (FragmentManager.java:1899)
  at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute (FragmentManager.java:1817)
  at androidx.fragment.app.FragmentManager.execPendingActions (FragmentManager.java:1760)
  at androidx.fragment.app.FragmentManager.dispatchStateChange (FragmentManager.java:2988)
  at androidx.fragment.app.FragmentManager.dispatchActivityCreated (FragmentManager.java:2898)
  at androidx.fragment.app.FragmentController.dispatchActivityCreated (FragmentController.java:263)
  at androidx.fragment.app.FragmentActivity.onStart (FragmentActivity.java:351)
  at androidx.appcompat.app.AppCompatActivity.onStart (AppCompatActivity.java:251)
  at android.app.Instrumentation.callActivityOnStart (Instrumentation.java:1457)
  at android.app.Activity.performStart (Activity.java:8259)
  at android.app.ActivityThread.handleStartActivity (ActivityThread.java:3776)
  at android.app.servertransaction.TransactionExecutor.performLifecycleSequence (TransactionExecutor.java:221)
  at android.app.servertransaction.TransactionExecutor.cycleToPath (TransactionExecutor.java:201)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleState (TransactionExecutor.java:173)
  at android.app.servertransaction.TransactionExecutor.execute (TransactionExecutor.java:97)
  at android.app.ActivityThread$H.handleMessage (ActivityThread.java:2311)
  at android.os.Handler.dispatchMessage (Handler.java:111)
  at android.os.Looper.loopOnce (Looper.java:238)
  at android.os.Looper.loop (Looper.java:357)
  at android.app.ActivityThread.main (ActivityThread.java:8090)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1026)

[SergeyZhukovsky]

That is related to that issue as well #27089

[SergeyZhukovsky]

There is a community thread about this as well https://community.brave.com/t/app-stopped-working-when-trying-to-access-passwords/448201

[kjozwiak]

The above requires 1.50.110 or higher for 1.50.x verification 👍

[kjozwiak]

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.112 Chromium: 112.0.5615.49 (Official Build) (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TQ2A.230305.008.E1

Went through the STR/Cases outlined via #29344 (comment) and ensured that the Password Manager was working when Android OS was set to Bold and not Bold.

screen-20230403-233838.mp4