[Android] [Rewards 2.5 Phase 4] vBAT expiry notice is shown when past date is set in the vbatDeadline at the /parameter endpoint

[GeetaSarvadnya]

Description

Found while testing #27883
[Rewards 2.5 Phase 4] vBAT expiry notice is shown when past date is set in the vbatDeadline at the /parameter endpoint

Steps to Reproduce

1. Follow the steps from scenario 2 via https://docs.google.com/document/d/1YVa6Wx4kMd90Q7mfx29iW--xa4tPNl7YXc486CkYQAI/edit#heading=h.t2vdk6dnw3tr
2. Open brave://settings, vBAT expiry notice is NOT shown as expected
3. Open BR panel vBAT expiry notice is shown, which is NOT as expected as the past date is set at the /parameter endpoint

Actual result:

past date is set at the /parameter endpoint

[ REQUEST ]
    > URL: https://api.rewards.bravesoftware.com/v1/parameters
    > Method: GET
.....
  [ RESPONSE - OnResponse ]
    > Url: https://api.rewards.bravesoftware.com/v1/parameters
    > Result: Success
    > HTTP Code: 200
    > Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.262301,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","US","GB"],"block":[]},"uphold":{"allow":["AU","AT","BE","CA","CO","DK","FI","HK","IE","IT","NL","NO","PL","PT","SG","ES","SE","US","GB","IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"processing","uphold":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-25T04:00:00Z","vbatExpired":false}
2023-03-01 14:02:57.164 9140-9140/? V/chromium: [VERBOSE1:api_parameters.cc(90)] Params timer set for 11286 s

Expected result:

vBAT expiry notice should NOT be shown when past date is set at the /parameter endpoint

Reproduces how often:

Easy

Brave version (brave://version info)

1.49.108

Version/Channel Information:

• Can you reproduce this issue with the current release? NA
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @deeppandya @Miyayes

[deeppandya]

@GeetaSarvadnya regarding this issue, you should set vbatExpired to true when you try to set the expiry date. it should behave the same on desktop as well.

[GeetaSarvadnya]

@deeppandya The same case works fine on Desktop with vbatExpired = false and vbatDeadline to past date

[Miyayes]

Aim for 1.49.x maintenance release // we have some time on this one because it will only come into play nearer the actual vBAT sunset deadline date.

[kjozwiak]

The above requires 1.58.93 or higher for 1.58.x verification 👍

[GeetaSarvadnya]

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.58.110

• Verified the test plan from [Android] [Rewards 2.5 Phase 4] vBAT expiry notice is shown when past date is set in the vbatDeadline at the /parameter endpoint #28817 (comment) and confirmed that there is no vBAT expiry notice when past date is set at the /parameter endpoint

Example	Example	Example

[ REQUEST ]
    > URL: https://api.rewards.bravesoftware.com/v1/parameters
    > Method: GET
----
[ RESPONSE - OnResponse ]
    > Url: https://api.rewards.bravesoftware.com/v1/parameters
    > Result: Success
    > HTTP Code: 200
    > Body: {"autocontribute":{"choices":[1,2,3,5,7,10,20],"defaultChoice":1},"batRate":0.170927,"custodianRegions":{"bitflyer":{"allow":["JP"],"block":[]},"gemini":{"allow":["US","CA","SG","GB"],"block":[]},"uphold":{"allow":["AD","AU","AR","AT","BE","BR","BS","BZ","CA","CH","CL","CO","CR","CY","CZ","DK","EC","EE","FI","FR","GD","GT","GR","HK","HN","HU","IE","IS","IT","JM","KY","LI","LT","LV","LU","MC","MT","MX","NI","NO","NZ","PE","PT","PY","SG","TR","UY","ES","SE","GB","US","UM","ZA","PL","SK","HR","SI","GR","TW"],"block":[]},"zebpay":{"allow":["IN"],"block":[]}},"payoutStatus":{"bitflyer":"complete","gemini":"complete","payoutDate":"","unverified":"complete","uphold":"off","zebpay":"complete"},"tips":{"defaultMonthlyChoices":[1.25,5,10.5],"defaultTipChoices":[1.25,5,10.5]},"vbatDeadline":"2023-01-25T04:00:00Z","vbatExpired":false}
2023-09-04 16:51:03.948 19055-19055/? V/chromium: [VERBOSE1:api_parameters.cc(88)] Params timer set for 10873 s