Brave News doesn't update the publisher cache on unsubscribe

[fallaciousreasoning]

Description

Unsubscribing from a source doesn't trigger the list of sources to update until the browser is restarted

Steps to Reproduce

1. Subscribe to two sources
2. Reload the NTP
3. Unsubscribe from one source
4. Reload the NTP
5. View sources

Actual result:

The source you just unsubscribed from is visible again

Expected result:

The source is gone

Reproduces how often:

Every time

Mitigations

Subscribing to a source, or restarting the browser will correctly show the source as unsubscribed.

[kjozwiak]

The above requires 1.49.117 or higher for 1.49.x verification 👍

[kjozwiak]

@fallaciousreasoning is this valid on Android with the old UI/UX? That's currently only on 1.50.x at the moment and not 1.49.x.

[Uni-verse]

Verified on Samsung Galaxy S21 5G using version

Brave	1.49.117 Chromium: 111.0.5563.50 (Official Build) (64-bit) 
Revision	39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS	Android 13; Build/TP1A.220624.014

Using STR in #28765 (comment)

Precondition: Brave news v2 enabled in brave://flags

• Ensured unsubscribing from following sources will update the feed accordingly
• Ensured unsubscribing works for popular sources, suggestions and channels.
• Ensured user is able to unsubscribe from sources on existing profile after upgrading app version.
• Ensured that disabling sources from NTP will unfollow in the news settings list - [Follow up to 28765] Disabling news source using context menu is not unfollowing from news sources list #28865

start with 3 sources	confirm CNN in feed	remove CNN source	confirm update feed prompt	confirm feed

[MadhaviSeelam]

Verification PASSED using

Brave | 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Upgrade:

1. Install 1.48.171
2. launch Brave
3. Open a new-tab page
4. click Turn on Brave News
5. click Follow for sources - NASA Image of the Day and The Spruce Easts
6. Un followed Top sources in the sidebar for easier view of just the subscribed sources
7. closed Dashboard
8. Refreshed NTP
9. verified both articles from both the news sources are shown
10. click Customize to return to Brave News Dashboard
11. clicked Unfollow on The Spruce Eats
12. close the Dashboard and return to NTP
13. click Load new content or refresh the page

Reproduced the issue that the articles from The Spruce Eats are shown.

steo 4	step 5	step 10	step 9	step 12	reproduced the issue

After Upgrade:

1. Close the browser from step 15
   • Articles from The Spruce Eats are shown
2. Install 1.49.118
3. Upgrade to 1.49.118
4. refresh NTP

Confirmed articles from The Spruce Eats no longer shown and feed is updated accordingly

step 1	step 3	results

New Install

1. Install 1.49.118
2. launch Brave
3. Open a new-tab page
4. click Turn on Brave News
5. click Customize
6. click Follow for sources - NASA Image of the Day and The Spruce Easts
7. Un followed Top sources in the sidebar for easier view of just the subscribed sources
8. clicked Back to Dashboard
9. Refreshed NTP
10. confirmed both articles from both the news sources are shown
11. click Customize to return to Brave News Dashboard
12. clicked Unfollow on The Spruce Eats
13. close the Dashboard and return to NTP
14. click Load new content or refresh the page

Confirmed articles from The Spruce Eats no longer shown and feed is updated accordingly

step 4	step 5	step 6	step 10	step 12	step 14	results