Skip to content

[Android] Fix spelling error "Accourding" in Limited functionality toast notification #28215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Miyayes opened this issue Feb 1, 2023 · 3 comments · Fixed by brave/brave-core#17001
Closed

[Android] Fix spelling error "Accourding" in Limited functionality toast notification #28215

Miyayes opened this issue Feb 1, 2023 · 3 comments · Fixed by brave/brave-core#17001
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 1, 2023

Description

image

Fix "Accourding".

From: #27743 (comment)

cc: @LaurenWags
@Miyayes Miyayes added feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality labels Feb 1, 2023
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 1, 2023
@deeppandya deeppandya mentioned this issue Feb 2, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 2, 2023
@Miyayes
Copy link
Collaborator Author

Miyayes commented Feb 2, 2023

I wonder if we can get this into 1.49.x since it's still early in that cycle, and this is actually a pretty common/visible toast notification for users.

@brave-builds brave-builds mentioned this issue Feb 3, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.49.92 or higher for 1.49.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 2, 2023
@GeetaSarvadnya
Copy link

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.49.116

Light mode Dark mode
Screenshot_20230303-133849_Brave - Beta Screenshot_20230303-134002_Brave - Beta

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 3, 2023
This was referenced Mar 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Update uphold limited functionality notification text brave/brave-core
5 participants
@kjozwiak @deeppandya @Miyayes @GeetaSarvadnya @brave-builds