Skip to content

[Android] "Error: Limited Uphold Account Functionality" notification isn't shown for Insufficient capabilities case #27743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeetaSarvadnya opened this issue Jan 11, 2023 · 5 comments
Assignees
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

Description

"Error: Limited Uphold Account Functionality" notification isn't shown for Insufficient capabilities case

Steps to reproduce

  1. Follow the steps for Insufficient capabilities case under New Uphold notifications WalletStatus cleanup #24251 (comment)

Actual result

"Error: Limited Uphold Account Functionality" notification is not shown on the BR panel for Insufficient capabilities case

Expected result

Desktop

image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): all
  • Android version: 12

Brave version

1.47.165

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

CC: @brave/qa-team @Miyayes @deeppandya

@LaurenWags
Copy link
Member

@Miyayes @deeppandya looks like this notification used to be a modal (see #23849 for 1.42.x) but with this version is now a panel notification. Could be the reason it's not showing.

@deeppandya
Copy link
Contributor

@LaurenWags we used to show the same modal on brave:rewards page after the verification. It seems to be new. I will look into it

@Miyayes Miyayes changed the title "Error: Limited Uphold Account Functionality" notification isn't shown for Insufficient capabilities case [Android] "Error: Limited Uphold Account Functionality" notification isn't shown for Insufficient capabilities case Jan 11, 2023
@Miyayes Miyayes added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jan 11, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 13, 2023

In this Android case:

  • Implement these toast notifications on the Rewards panel.

@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 13, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 20, 2023

According to Deep, this should be fixed in 1.48.x. We should verify in there or higher.

@Miyayes Miyayes closed this as completed Jan 24, 2023
@Miyayes Miyayes added this to the 1.48.x - Beta milestone Jan 24, 2023
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 1, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Feb 1, 2023

Verified on Google Pixel 3 XL with Android 12 running 1.48.152.

Verified as part of #27055 (comment).

Generally:

  • Connected Uphold to rewards
  • Changed the GET /v0/me/capabilities endpoint’s response with Charles proxy, so that "enabled": false for either "key": "receives", or "key": "sends" (or both).
  • Waited ~15 minutes for the toast notification to appear:

Screenshot_20230201-145027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants