Custom Filter Lists UI in brave://adblock completely broken since Nightly builds went Chromium 110

[ghost]

Description

Chromium 110 completely broke the UI section that contains the custom filter lists. Custom lists don't show at all, so they can't be updated or unsubscribed or disabled. The only work around is to do it through editing the Local State file.

Console throws some errors about Could not find style data in module named null and 'TrustedHTML' and Trusted Type Expected - Blocked and polymer_bundled.min.js:1 , the errors only happen when opening brave://adblock page, other pages don't cause that problem. I don't think these errors have to do with this issue #27647 made by @rebron but I better report this, because I didn't see any other issue talking about Chromium 110 breaking the custom lists UI.

Thank you.

Steps to Reproduce

1. Go to brave://adblock
2. Add a list (if empty) should trigger the problem. (If custom lists were added before, the problem should be present.)

Actual result:

Blank UI no custom filter list, names, buttons or anything

Expected result:

Being able to see the list of custom filter lists and update them, disable them or remove them.

Reproduces how often:

Always since first nightly with Chromium 110.

Brave version (brave://version info)

Nightly 1.49.75 Chromium: 110.0.5481.52

Version/Channel Information:

• Can you reproduce this issue with the current release? no
• Can you reproduce this issue with the beta channel? no
• Can you reproduce this issue with the nightly channel? yes (since Nightly is the only build with Chromium 110)

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? no
• Does the issue resolve itself when disabling Brave Rewards? no
• Is the issue reproducible on the latest version of Chrome? no, because it is a Brave specific feature.

Miscellaneous Information:

When fixed, would be good if the UI was tested with more than 15 or 20 custom lists, because last time I was able to update them (before 110), there was a weird behavior after updating the lists that were located at the bottom.
It happens when many list are added, and It's like the UI with the lists collapses, and every list gets hidden/moved upwards, then it gets expanded again after a second, making it slow to update, because there is no way to click the button ⋮ -> update quickly, while the UI gets all weird.
Not critical or related to Chromium 110, but would be good if someone at Brave checked that to understand the issue so it can be fixed in the future, if issue is still present and exists.
Custom lists UI seems to have some issues, would be good if all were covered.

[kjozwiak]

The above requires 1.48.158 or higher for 1.48.x verification 👍

[btlechowski]

Verification passed on

Brave	1.48.158 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#17059 (comment)

Test Case 1 - clean profile

• installed 1.48.158
• opened brave://settings/shields/filters
• added the following custom filter list via Add custom filter lists without any issues/failures via DevTools
  • https://easylist-downloads.adblockplus.org/easylistpolish.txt

Verified the custom filters are applied:
Open sadownictwo.com.pl and verify that top banner is gone

Before	After

Test case 2 - upgrade profile

• installed 1.47.x
• opened brave://settings/shields/filters
• added the following custom filter via Add custom filter lists without any issues (appears in the list as expected)
  • https://easylist-downloads.adblockplus.org/easylistpolish.txt
• updated to 1.48.158
• ensured that the filter is still being displayed via Custom Filter under brave://settings/shields/filters
  • ensured that there's no errors/failures via DevTools when viewing the console

1.47.x	1.48.x

Verified the custom filters are applied:
Open sadownictwo.com.pl and verify that the top banner is gone

[stephendonner]

Verification PASSED using

Brave	1.48.158 Chromium: 110.0.5481.77 (Official Build) (x86_64)
Revision	65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS	macOS Version 11.7.3 (Build 20G1116)

Reproduced the issue in 1.49.89

example	example

Case 1: Clean profile - PASSED

1. installed 1.48.158
2. opened brave://settings/shields/filters
3. added the following custom filter list via Add custom filter lists without any issues/failures via DevTools:
   https://easylist-downloads.adblockplus.org/easylistpolish.txt

example	example

Case 2: Upgrade - PASSED

1. installed 1.47.x
2. opened brave://settings/shields/filters
3. added the following custom filter via Add custom filter lists without any issues (appears in the list as expected):
4. https://easylist-downloads.adblockplus.org/easylistpolish.txt
5. updated to 1.48.158
6. ensured that the filter is still being displayed via Custom Filter under brave://settings/shields/filters
7. ensured that there's no errors/failures via DevTools when viewing the console

Verified the custom filters are applied:
Opened sadownictwo.com.pl and verified that the top banner is gone

example	example	example

[MadhaviSeelam]

Verification PASSED using

Brave | 1.48.158 Chromium: 110.0.5481.77 (Official Build) (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)

Case 1: New profile

• installed 1.48.158
• opened brave://settings/shields/filters
• added the following custom filter list via Add custom filter lists without any issues/failures via DevTools:
  • https://easylist-downloads.adblockplus.org/easylistpolish.txt
  • https://raw.githubusercontent.com/DandelionSprout/adfilt/master/Anti-'Google%20Hangouts'%20List.txt

Case 2: Upgrade

• installed 1.47.186
• opened brave://settings/shields/filters
• added the following custom filter via Add custom filter lists without any issues (appears in the list as expected):
• https://easylist-downloads.adblockplus.org/easylistpolish.txt
• updated to 1.48.158
• ensured that the filter is still being displayed via Custom Filter under brave://settings/shields/filters
• ensured that there's no errors/failures via DevTools when viewing the console
• Verified the custom filters are applied:
• Opened sadownictwo.com.pl and verified that the top banner is gone

1.47.186	1.48.158	ex	ex

[bsclifton]

Hi @Emi-TheDhamphirInLoveUnderTheFrozenStar

Just wanted to take a minute to thank you for opening this. There are definitely things which break as we upgrade Chromium - there were a few other areas we didn't find until later too. Definitely nothing broken intentionally! I saw your original comment and the edit - huge thanks for your patience.

Having feedback on Nightly is massively important to us - please do keep reporting issues that you find 😄

[ghost]

@bsclifton I appreciate the message and I appreciate all the work you and the Brave team do!
I was just worried people's list would appear 'gone' and then people would push the red button and complain, when it could have been avoided, but it's good you guys rushed to fix it!

And don't worry I will keep reporting! lol
For example, I finally just opened an issue about my Miscellaneous Information where I talk about the lists 'collapsing' when updating, #28894, not critical like this bug where lists didn't display correctly, but still ugly and annoying, especially when I switch to use Default lists as custom for testing purposes.

Thanks again and have a good day!